Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isMobilePhone): Fix el-GR validation - Add missing ranges + correctly exclude certain ranges #2112

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

pano9000
Copy link
Contributor

@pano9000 pano9000 commented Dec 5, 2022

Previous RegExp for el-GR had some flaws and was
a) missing some number ranges (like 685, etc.)
b) not excluding certain number ranges (i.e. overly permissive RegExp), like 692 or 696

References:
Official Greek numbering plan on the ITU website, last updated in 2021:
https://web.archive.org/web/20221205170159/https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000550002PDFE.pdf

See #2111 for some more in-depth info

This fixes #2111

Checklist

Thank you!

  • PR contains only changes related; no stray files, etc.
  • [ ] README updated (where applicable)
  • Tests written (where applicable)

@pano9000
Copy link
Contributor Author

pano9000 commented Dec 5, 2022

oops, looks like I based my branch off a wrong branch, let me try to fix that, the README.md should not have been part of this PR

EDIT: ok, fixed my previous mistake, sorry about that!

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d897415) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rubiin rubiin added ready-to-land For PRs that are reviewed and ready to be landed mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM and removed mc-to-land Just merge-conflict standing between the PR and landing. labels Jan 21, 2023
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ LGTM ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isMobilePhone: el-GR incomplete and partially wrong validation
5 participants