Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isMobilePhone): fix 'ro-RO' matching invalid numbers #2156

Merged

Conversation

pano9000
Copy link
Contributor

  • fixed the bug that would cause it to match invalid numbers
  • added tests for invalid numbers

fixes #2055

Checklist

  • PR contains only changes related; no stray files, etc.
  • [ ] README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d1f0f72) compared to base (f97e8d4).
Patch has no changes to coverable lines.

❗ Current head d1f0f72 differs from pull request most recent head cd237dc. Consider uploading reports for the commit cd237dc to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2335      2335           
  Branches       586       586           
=========================================
  Hits          2335      2335           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik
WikiRik previously approved these changes Jan 23, 2023
rubiin
rubiin previously approved these changes Jan 24, 2023
@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Jan 28, 2023
profnandaa
profnandaa previously approved these changes Jan 28, 2023
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* fixed the bug that would cause it to match invalid numbers
* added tests for invalid numbers

fixes validatorjs#2055
@pano9000 pano9000 dismissed stale reviews from profnandaa, rubiin, and WikiRik via d1f0f72 January 28, 2023 22:48
@pano9000 pano9000 force-pushed the fix_isMobilePhone_ro-RO_#2055 branch from d1f0f72 to cd237dc Compare January 28, 2023 23:33
@rubiin rubiin removed the mc-to-land Just merge-conflict standing between the PR and landing. label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isMobilePhone accept invalid phone numbers
4 participants