Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @segment dependencies #2598

Merged
merged 9 commits into from
Jun 19, 2022
Merged

Update @segment dependencies #2598

merged 9 commits into from
Jun 19, 2022

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Jun 15, 2022

Description

Updates segment related dependencies upgrade from com.segment.analytics.android:analytics:4.9.3 to com.segment.analytics.android:analytics:4.10.1 for Google PlayStore Compliance.

Other changes

N/A

Tested

Tested Locally on Android.

How others should test

This does not need to be tested by QA.

Related issues

N/A

Backwards compatibility

Yes

@MuckT MuckT requested a review from jeanregisser June 15, 2022 00:29
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #2598 (19c9ccc) into main (0e62180) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2598      +/-   ##
==========================================
- Coverage   79.54%   79.53%   -0.01%     
==========================================
  Files         592      592              
  Lines       21272    21272              
  Branches     3884     3884              
==========================================
- Hits        16920    16918       -2     
- Misses       4302     4304       +2     
  Partials       50       50              
Impacted Files Coverage Δ
src/web3/saga.ts 77.77% <0.00%> (-3.04%) ⬇️
src/tokens/utils.ts 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e62180...19c9ccc. Read the comment docs.

@MuckT
Copy link
Collaborator Author

MuckT commented Jun 15, 2022

@jeanregisser is there a good way to ensure that this update is using >=com.segment.analytics.android:analytics:4.10.1?

@jeanregisser
Copy link
Member

@MuckT you can run ./gradlew app:dependencies from the android folder to check that it resolves to the version you expect.

@MuckT
Copy link
Collaborator Author

MuckT commented Jun 16, 2022

@jeanregisser thanks for the info! It looks like this puts our com.segment.analytics.android:analytics:4.10.4. There are some other dependencies that got updated; however, if there are no issues I don't see a downside to including these also.

@MuckT MuckT marked this pull request as ready for review June 17, 2022 00:09
Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipit! :shipit: 🚢

@MuckT MuckT added the automerge Have PR merge automatically when checks pass label Jun 17, 2022
@mergify mergify bot merged commit cfd8c12 into main Jun 19, 2022
@mergify mergify bot deleted the tomm/segment-4.10.1 branch June 19, 2022 19:08
@ValoraQA
Copy link

Hey @MuckT since NA is mentioned in how others should test , we are skipping this PR
Thanks.!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants