-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix known vulnerabilities #2614
Conversation
⬇️ This change reduces install size by 278.5 kB ⬇️🗂 See the Emerge size breakdown
🔎 See the full analysis (ec4767a) merging into main (cfd8c12) |
Codecov Report
@@ Coverage Diff @@
## main #2614 +/- ##
=======================================
Coverage 79.54% 79.54%
=======================================
Files 592 592
Lines 21272 21272
Branches 3884 3884
=======================================
+ Hits 16920 16921 +1
+ Misses 4302 4301 -1
Partials 50 50
Continue to review full report at Codecov.
|
Looks great, thank you Jean!!!! 🚀 |
Hey @MuckT we will check the above PR while performing BVT and Regression testing and update in the comment accordingly if any issues is faced |
Hey @MuckT we have verified the above PR while performing BVT's and here are the below links for the same Test Rail links: Devices : iPhone 13 mini (15.1.1), iPhone 12(14.7.1), Google Pixel 4a(12.0), Google Pixel XL(10.0) CC: @kathaypacific Thanks..!! |
Hey @MuckT we have verified the above PR while performing Regression testing and here are the below links for the same Test Rail links: Devices : iPhone 13 mini (15.1.1), Google Pixel 4a(12.0) CC: @kathaypacific Thanks..!! |
Description
@celo/utils
to fix vulnerability in@umpirsky/country-list
: GHSA-hj79-42mx-m4gr@celo/utils
caused a new parsing error with hermes as it doesn't support named capture groups in RegEx. It was solved by adding@babel/plugin-transform-named-capturing-groups-regex
to our babel transforms.shell-quote
to fix vulnerability: GHSA-g4rg-993r-mgx7Other changes
N/A
Tested
The app + phone verification should work as expected
How others should test
Please test the phone verification and confirm that it works as expected (there should be no change as a result of this PR)
Related issues
Discussed on Slack.
Backwards compatibility
Yes