Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix known vulnerabilities #2614

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Fix known vulnerabilities #2614

merged 4 commits into from
Jun 22, 2022

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented Jun 21, 2022

Description

Other changes

N/A

Tested

The app + phone verification should work as expected

How others should test

Please test the phone verification and confirm that it works as expected (there should be no change as a result of this PR)

Related issues

Discussed on Slack.

Backwards compatibility

Yes

@kathaypacific kathaypacific changed the title Fix vulnerability Fix known vulnerabilities Jun 21, 2022
@emerge-tools
Copy link

emerge-tools bot commented Jun 22, 2022

⬇️ This change reduces install size by 278.5 kB ⬇️

🗂 See the Emerge size breakdown
Item Install size
main.jsbundle ⬇️ 278.5 kB

🔎 See the full analysis (ec4767a) merging into main (cfd8c12)

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #2614 (ec4767a) into main (cfd8c12) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2614   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files         592      592           
  Lines       21272    21272           
  Branches     3884     3884           
=======================================
+ Hits        16920    16921    +1     
+ Misses       4302     4301    -1     
  Partials       50       50           
Impacted Files Coverage Δ
src/tokens/utils.ts 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd8c12...ec4767a. Read the comment docs.

@jeanregisser jeanregisser marked this pull request as ready for review June 22, 2022 09:32
@kathaypacific
Copy link
Collaborator Author

Looks great, thank you Jean!!!! 🚀

@jeanregisser jeanregisser merged commit cce253f into main Jun 22, 2022
@jeanregisser jeanregisser deleted the kathy/fix-country-list branch June 22, 2022 10:08
@ValoraQA
Copy link

Hey @MuckT we will check the above PR while performing BVT and Regression testing and update in the comment accordingly if any issues is faced

@ValoraQA
Copy link

ValoraQA commented Jun 27, 2022

Hey @MuckT we have verified the above PR while performing BVT's and here are the below links for the same

Test Rail links:
Android 10 : https://valoraapp.testrail.io/index.php?/runs/view/158&group_by=cases:section_id&group_order=asc
Android 12: https://valoraapp.testrail.io/index.php?/runs/view/159&group_by=cases:section_id&group_order=asc
iOS 14: https://valoraapp.testrail.io/index.php?/runs/view/161&group_by=cases:section_id&group_order=asc
iOS 15 : https://valoraapp.testrail.io/index.php?/runs/view/160&group_by=cases:section_id&group_order=asc

Devices : iPhone 13 mini (15.1.1), iPhone 12(14.7.1), Google Pixel 4a(12.0), Google Pixel XL(10.0)

CC: @kathaypacific

Thanks..!!

@ValoraQA
Copy link

ValoraQA commented Jul 6, 2022

Hey @MuckT we have verified the above PR while performing Regression testing and here are the below links for the same

Test Rail links:
Android 12: https://valoraapp.testrail.io/index.php?/runs/view/167&group_by=cases:section_id&group_order=asc
iOS 15 : https://valoraapp.testrail.io/index.php?/runs/view/166&group_by=cases:section_id&group_order=asc

Devices : iPhone 13 mini (15.1.1), Google Pixel 4a(12.0)

CC: @kathaypacific

Thanks..!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants