fix(pmp): change fullName to Url in addRepo

create util files for name extraction

angular.json

@@ -1182,6 +1182,32 @@
           "styleext": "scss"
         }
       }
+    },
+    "server-shared-util-repository": {
+      "projectType": "library",
+      "root": "libs/server/shared/util-repository",
+      "sourceRoot": "libs/server/shared/util-repository/src",
+      "prefix": "pimp-my-pr",
+      "architect": {
+        "lint": {
+          "builder": "@angular-devkit/build-angular:tslint",
+          "options": {
+            "tsConfig": [
+              "libs/server/shared/util-repository/tsconfig.lib.json",
+              "libs/server/shared/util-repository/tsconfig.spec.json"
+            ],
+            "exclude": ["**/node_modules/**", "!libs/server/shared/util-repository/**"]
+          }
+        },
+        "test": {
+          "builder": "@nrwl/jest:jest",
+          "options": {
+            "jestConfig": "libs/server/shared/util-repository/jest.config.js",
+            "tsConfig": "libs/server/shared/util-repository/tsconfig.spec.json"
+          }
+        }
+      },
+      "schematics": {}
     }
   },
   "cli": {

libs/server/repository/api-rest/src/lib/controllers/repository.controller.ts

@@ -6,6 +6,7 @@ import {
 } from '@pimp-my-pr/server/repository/core/application-services';
 import { AddRepositoryDto } from '../dtos/add-repository.dto';
 import { RepositoryEntity } from '@pimp-my-pr/server/repository/core/domain';
+import { extractFullName } from '@pimp-my-pr/server/shared/util-repository';
 
 @ApiTags('repository')
 @Controller('repository')
@@ -21,7 +22,7 @@ export class RepositoryController {
   addRepository(@Body() addRepositoryDto: AddRepositoryDto): Promise<void> {
     return this.repositoryFacade.addRepository(
       new AddRepositoryCommand(
-        addRepositoryDto.repositoryName,
+        extractFullName(addRepositoryDto.repositoryUrl),
         addRepositoryDto.maxLines,
         addRepositoryDto.maxWaitingTime
       )

libs/server/repository/api-rest/src/lib/dtos/add-repository.dto.ts

@@ -2,7 +2,7 @@ import { ApiProperty } from '@nestjs/swagger';
 
 export class AddRepositoryDto {
   @ApiProperty()
-  repositoryName: string;
+  repositoryUrl: string;
 
   @ApiProperty()
   maxLines?: number;

libs/server/shared/util-repository/README.md

@@ -0,0 +1,7 @@
+# server-shared-utils
+
+This library was generated with [Nx](https://nx.dev).
+
+## Running unit tests
+
+Run `nx test server-shared-utils` to execute the unit tests.

libs/server/shared/util-repository/jest.config.js

@@ -0,0 +1,9 @@
+module.exports = {
+  name: 'server-shared-utils',
+  preset: '../../../../jest.config.js',
+  transform: {
+    '^.+\\.[tj]sx?$': 'ts-jest'
+  },
+  moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'html'],
+  coverageDirectory: '../../../../coverage/libs/server/shared/utils'
+};

libs/server/shared/util-repository/src/index.ts

@@ -0,0 +1 @@
+export * from './lib/name-extract/repository-name-extract.util';

libs/server/shared/util-repository/src/lib/name-extract/repository-name-extract.util.ts

@@ -0,0 +1,21 @@
+import { URL } from 'url';
+
+const allowedDomains = ['github', 'bitbucket'];
+
+function isHostAllowed(host: string): boolean {
+  return allowedDomains.reduce((accumulator, currentValue) => {
+    if (accumulator) return accumulator;
+    return host.includes(currentValue);
+  }, false);
+}
+
+export function extractFullName(repoUrl: string): string {
+  const url = new URL(repoUrl);
+  if (isHostAllowed(url.host)) {
+    const pathArr = url.pathname.slice(1).split('/');
+    if (pathArr.length > 1) {
+      return `${pathArr[0]}/${pathArr[1]}`;
+    }
+  }
+  return '';
+}

libs/server/shared/util-repository/tsconfig.json

@@ -0,0 +1,7 @@
+{
+  "extends": "../../../../tsconfig.json",
+  "compilerOptions": {
+    "types": ["node", "jest"]
+  },
+  "include": ["**/*.ts"]
+}

libs/server/shared/util-repository/tsconfig.lib.json

@@ -0,0 +1,9 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "outDir": "../../../../dist/out-tsc",
+    "types": []
+  },
+  "exclude": ["**/*.spec.ts"],
+  "include": ["**/*.ts"]
+}

libs/server/shared/util-repository/tsconfig.spec.json

@@ -0,0 +1,9 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "outDir": "../../../../dist/out-tsc",
+    "module": "commonjs",
+    "types": ["jest", "node"]
+  },
+  "include": ["**/*.spec.ts", "**/*.spec.tsx", "**/*.spec.js", "**/*.spec.jsx", "**/*.d.ts"]
+}

libs/server/shared/util-repository/tslint.json

@@ -0,0 +1 @@
+{ "extends": "../../../../tslint.json", "rules": [] }

nx.json

@@ -118,6 +118,9 @@
     },
     "server-repository-core-domain-services": {
       "tags": ["platform:server", "scope:repository", "type:domain-services"]
+    },
+    "server-shared-util-repository": {
+      "tags": ["platform:server", "scope:shared", "type:util"]
     }
   }
 }

tsconfig.json

@@ -94,6 +94,9 @@
       ],
       "@pimp-my-pr/pmp-web/repository/repository-settings/feature": [
         "libs/pmp-web/repository/repository-settings/feature/src/index.ts"
+      ],
+      "@pimp-my-pr/server/shared/util-repository": [
+        "libs/server/shared/util-repository/src/index.ts"
       ]
     }
   },

tslint.json

@@ -70,7 +70,12 @@
           },
           {
             "sourceTag": "type:api",
-            "onlyDependOnLibsWithTags": ["type:application-services", "type:domain", "type:shell"]
+            "onlyDependOnLibsWithTags": [
+              "type:application-services",
+              "type:domain",
+              "type:shell",
+              "type:util"
+            ]
           },
           {
             "sourceTag": "type:application",