feat(pmp): edit repository in settings - front #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABartoszko
requested review from
Stefaneek and
Sikora00
and removed request for
Stefaneek
Sikora00
suggested changes
May 6, 2020
| } | ||
|
|
||
| initForm(): void { | ||
| this.form = this.fb.group({ |
There was a problem hiding this comment.
create service for this component to reduce the complexity.
| }) | ||
| .subscribe( | ||
| () => { | ||
| // TODO: move to separate lib with service e.g SnackbarService |
| this.matDialog.open(AddRepositoryDialogComponent, { | ||
| width: '350px' // Consider better way of setting width of dialogs | ||
| this.matDialog.open(AddEditRepositoryDialogComponent, { | ||
| width: '350px', // Consider better way of setting width of dialogs, |
MaciejSikorski
suggested changes
May 7, 2020
| @@ -0,0 +1,3 @@ | |||
| .add-edit-repository-dialog { | |||
| width: 400px; | |||
There was a problem hiding this comment.
Is that the best solution in the context of RWD?
ABartoszko
force-pushed
the
feature/PMP-107-1
branch
from
68e49cb
to
8a71916
Compare
ABartoszko
force-pushed
the
feature/PMP-107-1
branch
from
8a71916
to
93412fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #107