feat(pmp): edit repository in settings - backend #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sikora00
suggested changes
May 3, 2020
| async execute(command: EditRepositoryCommand): Promise<void> { | ||
| const { repositoryId, maxLines, maxWaitingTime } = command; | ||
|
|
||
| const repositoryData = await this.repositoryRepository.getById(repositoryId); |
There was a problem hiding this comment.
In this case, it is just a repository. In opposite to add action where we wanted to execute construct mothod.
|
|
||
| const repositoryData = await this.repositoryRepository.getById(repositoryId); | ||
|
|
||
| const updatedRepository = { ...repositoryData, maxLines, maxWaitingTime } as RepositoryEntity; |
There was a problem hiding this comment.
add edit method in the RepositoryEntity end update properties directly like that:
edit(writeModel: RepositoryEditWriteModel): void {
this.maxLines = writeModel.maxLines;
...
}
ABartoszko
force-pushed
the
feature/PMP-107-2
branch
2 times, most recently
from
68e49cb
to
c0bfbcf
Compare
MaciejSikorski
suggested changes
May 7, 2020
| @@ -0,0 +1,4 @@ | |||
| export interface RepositoryEditWriteModel { | |||
| maxLines: number; | |||
There was a problem hiding this comment.
Shouldn't they be optional?
ABartoszko
force-pushed
the
feature/PMP-107-2
branch
2 times, most recently
from
b2dcf79
to
9bd9588
Compare
ABartoszko
force-pushed
the
feature/PMP-107-2
branch
from
9bd9588
to
26f5187
Compare
MaciejSikorski
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #107