Precompute default regexp (#662)

valyala · Sep 25, 2019 · dc9b54d · dc9b54d
1 parent be93fbd
commit dc9b54d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/expvarhandler/expvar.go b/expvarhandler/expvar.go
@@ -13,6 +13,8 @@ import (
 var (
 	expvarHandlerCalls = expvar.NewInt("expvarHandlerCalls")
 	expvarRegexpErrors = expvar.NewInt("expvarRegexpErrors")
+
+	defaultRE = regexp.MustCompile(".")
 )
 
 // ExpvarHandler dumps json representation of expvars to http response.
@@ -52,7 +54,7 @@ func ExpvarHandler(ctx *fasthttp.RequestCtx) {
 func getExpvarRegexp(ctx *fasthttp.RequestCtx) (*regexp.Regexp, error) {
 	r := string(ctx.QueryArgs().Peek("r"))
 	if len(r) == 0 {
-		r = "."
+		return defaultRE, nil
 	}
 	rr, err := regexp.Compile(r)
 	if err != nil {