Requests with incomplete bodies no longer cause log noise (#682)

* #660 Incorrect content length

* fix

* unexpected EOF is expected

* Prevent test from panicing should err ever be nil

server_test.go

@@ -3147,6 +3147,24 @@ func TestMaxWriteTimeoutPerRequest(t *testing.T) {
 	}
 }
 
+func TestIncompleteBodyReturnsUnexpectedEOF(t *testing.T) {
+	rw := &readWriter{}
+	rw.r.WriteString("POST /foo HTTP/1.1\r\nHost: google.com\r\nContent-Length: 5\r\n\r\n123")
+	s := &Server{
+		Handler: func(ctx *RequestCtx) {},
+	}
+	ch := make(chan error)
+	go func() {
+		ch <- s.ServeConn(rw)
+	}()
+	select {
+	case err := <-ch:
+		if err == nil || err.Error() != "unexpected EOF" {
+			t.Fatal(err)
+		}
+	}
+}
+
 func verifyResponse(t *testing.T, r *bufio.Reader, expectedStatusCode int, expectedContentType, expectedBody string) {
 	var resp Response
 	if err := resp.Read(r); err != nil {

workerpool.go

@@ -214,6 +214,7 @@ func (wp *workerPool) workerFunc(ch *workerChan) {
 			if wp.LogAllErrors || !(strings.Contains(errStr, "broken pipe") ||
 				strings.Contains(errStr, "reset by peer") ||
 				strings.Contains(errStr, "request headers: small read buffer") ||
+				strings.Contains(errStr, "unexpected EOF") ||
 				strings.Contains(errStr, "i/o timeout")) {
 				wp.Logger.Printf("error when serving connection %q<->%q: %s", c.LocalAddr(), c.RemoteAddr(), err)
 			}