Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCPDialer :: DNSCacheDuration option #1046

Merged
merged 5 commits into from
Jun 18, 2021
Merged

Conversation

eeertekin
Copy link
Contributor

@eeertekin eeertekin commented Jun 14, 2021

TCPDialer{} extended to support DNSCacheDuration

image

Copy link
Collaborator

@erikdubbelboer erikdubbelboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather you add DNSCacheDuration as option to TCPDialer.

@eeertekin eeertekin changed the title DefaultDNSCacheDuration :: Changed to var TCPDialer :: DNSCacheDuration option Jun 14, 2021
tcpdialer.go Show resolved Hide resolved
tcpdialer.go Outdated Show resolved Hide resolved
@erikdubbelboer erikdubbelboer merged commit c12a061 into valyala:master Jun 18, 2021
@erikdubbelboer
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants