Add RequestHeader.RawHeaders() #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
force-pushed
the
rawheaders
branch
from
98de8a1
to
e29392a
Compare
erikdubbelboer
added a commit
that referenced
this pull request
Oct 5, 2018
Header normalization has been changed since pull request #378 was made. These days header case doesn't matter when looking up headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about this one. At first it was ok but because of the messy header parsing and returning this turned out to be buggy and required some fixes to get working properly. I also don't like the test, it seems to test a lot more than is required for the code changes.
See: erikdubbelboer#18, erikdubbelboer#27, erikdubbelboer#29 and erikdubbelboer#40