Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client should return ErrTimeout on timeout #736

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Client should return ErrTimeout on timeout #736

merged 1 commit into from
Jan 31, 2020

Conversation

erikdubbelboer
Copy link
Collaborator

Not ErrConnectionClosed which is incorrect.

Fixes: #355

@erikdubbelboer
Client should return ErrTimeout on timeout
3037539 
Not ErrConnectionClosed which is incorrect.

Fixes: #355
@erikdubbelboer erikdubbelboer mentioned this pull request Jan 31, 2020
Closed
@erikdubbelboer erikdubbelboer merged commit 69d5c37 into master Jan 31, 2020
@erikdubbelboer erikdubbelboer deleted the client-timeout branch January 31, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sometimes the error should be "tcp read xxx->xx i/o read timeout", but give me a ErrConnectionClosed error .
1 participant
@erikdubbelboer