Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart PipelineClient worker on error #834

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Restart PipelineClient worker on error #834

merged 1 commit into from
Jun 16, 2020

Conversation

erikdubbelboer
Copy link
Collaborator

Fixes #832

@erikdubbelboer erikdubbelboer mentioned this pull request Jun 12, 2020
Closed
@erikdubbelboer erikdubbelboer force-pushed the fix-pipeline-reconnect branch 2 times, most recently from 019df1a to 9904be4 Compare June 12, 2020 20:25
@lithdew
Copy link

lithdew commented Jun 13, 2020 •
edited
Loading

I will check more thoroughly later today, apologies for the delay - on a quick skim though, should chW be reset when there are pending messages available?

As follows in the note below:

// Do not reset c.chW to nil, since it may contain	
// pending requests, which could be served on the next	
// connection to the host.

@erikdubbelboer
Copy link
Collaborator Author

chW is only reset when there are no message pending.

@lithdew
Copy link

lithdew commented Jun 16, 2020

chW is only reset when there are no message pending.

Tested it on my end and it works; LGTM?

@erikdubbelboer erikdubbelboer merged commit 9dd7979 into master Jun 16, 2020
@erikdubbelboer erikdubbelboer deleted the fix-pipeline-reconnect branch June 16, 2020 09:58
@erikdubbelboer
Copy link
Collaborator Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition on read timeout causes deadlock in PipelineClient.
2 participants
@erikdubbelboer @lithdew