fix: don't set packages in setup.py #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the following warning: > /usr/local/lib/python3.11/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning: Installing 'raincloudy.aio' as data is deprecated, please list it in `packages`. > !! > > > ############################ > # Package would be ignored # > ############################ > Python recognizes 'raincloudy.aio' as an importable package, > but it is not listed in the `packages` configuration of setuptools. > > 'raincloudy.aio' has been automatically added to the distribution only > because it may contain data files, but this behavior is likely to change > in future versions of setuptools (and therefore is considered deprecated). > > Please make sure that 'raincloudy.aio' is included as a package by using > the `packages` configuration field or the proper discovery methods > (for example by using `find_namespace_packages(...)`/`find_namespace:` > instead of `find_packages(...)`/`find:`). > > You can read more about "package discovery" and "data files" on setuptools > documentation page. > > > !! The fix would be to add raincloudy.aio to the packages field, but according to the setuptools documentation[1], that field can now be omitted entirely in most cases, and setuptools will infer what to do. This seems to work for raincloudy. [1]: https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#automatic-discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following warning:
The fix would be to add raincloudy.aio to the packages field, but according to the setuptools documentation, that field can now be omitted entirely in most cases, and setuptools will infer what to do. This seems to work for raincloudy.