Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated BoolField tests to @testing-library/react #1268

Merged
merged 7 commits into from
Jun 19, 2023
Merged

Migrated BoolField tests to @testing-library/react #1268

merged 7 commits into from
Jun 19, 2023

Conversation

piotrpospiech
Copy link
Collaborator

@piotrpospiech piotrpospiech commented May 26, 2023 •
edited
Loading

Migrated BoolField tests to @testing-library/react

@github-actions github-actions bot added Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 3 Affects the uniforms-bootstrap3 package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: Material-UI Affects the uniforms-material package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package labels May 26, 2023
@piotrpospiech piotrpospiech force-pushed the testing-library-boolfield branch 2 times, most recently from 0c93295 to 9baa095 Compare May 26, 2023 09:58
@codecov
Copy link

codecov bot commented May 26, 2023 •
edited
Loading

Codecov Report

Merging #1268 (db7fb59) into master (1c69877) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1268   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files         231      231           
  Lines        3821     3821           
  Branches     1029     1029           
=======================================
  Hits         3688     3688           
  Misses         12       12           
  Partials      121      121

@piotrpospiech piotrpospiech changed the title Migrated LongTextField tests to @testing-library/react Migrated BoolField tests to @testing-library/react May 26, 2023
@piotrpospiech piotrpospiech marked this pull request as ready for review May 31, 2023 19:53
radekmie
radekmie previously approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll definitely have to think about not having so many flags in this suite, but that can come later.

radekmie
radekmie previously approved these changes Jun 16, 2023
View reviewed changes
Monteth
Monteth previously approved these changes Jun 16, 2023
View reviewed changes
@Monteth Monteth requested a review from ErnestTeluk June 16, 2023 10:48
@piotrpospiech piotrpospiech dismissed stale reviews from Monteth and radekmie via db7fb59 June 16, 2023 10:49
@radekmie radekmie merged commit be39d3e into master Jun 19, 2023
@radekmie radekmie deleted the testing-library-boolfield branch June 19, 2023 12:38
@kestarumper kestarumper mentioned this pull request Feb 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radekmie radekmie radekmie approved these changes

@zaxovaiko zaxovaiko zaxovaiko approved these changes

@ErnestTeluk ErnestTeluk ErnestTeluk approved these changes

@Monteth Monteth Monteth left review comments

@wadamek65 wadamek65 Awaiting requested review from wadamek65 wadamek65 is a code owner

Assignees
No one assigned
Labels
Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 3 Affects the uniforms-bootstrap3 package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: Material-UI Affects the uniforms-material package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@piotrpospiech @radekmie @Monteth @zaxovaiko @ErnestTeluk