Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated ListItemField tests to @testing-library/react #1304

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Migrated ListItemField tests to @testing-library/react #1304

merged 8 commits into from
Feb 23, 2024

Conversation

zendranm
Copy link
Member

@zendranm zendranm commented Feb 15, 2024 •
edited by piotrpospiech
Loading

Is part of #1130

  • added new tests to ListItemField RTL suites
  • removed enzyme ListItemField tests

Removed renders AutoField test, because there is no way to check if default children component will be rendered in RTL. renders children if specified test is testing similar behaviour.

@github-actions github-actions bot added Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: Bootstrap 3 Affects the uniforms-bootstrap3 package Theme: Unstyled Affects the uniforms-unstyled package labels Feb 15, 2024
@github-actions github-actions bot added Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: Material-UI Affects the uniforms-material package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package labels Feb 16, 2024
@piotrpospiech piotrpospiech changed the title Migrate ListItemField tests from Enzyme Migrated ListItemField tests to @testing-library/react Feb 16, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a6ca83) 94.66% compared to head (0d5f55e) 94.66%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1304   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         231      231           
  Lines        3821     3821           
  Branches     1029     1029           
=======================================
  Hits         3617     3617           
  Misses         82       82           
  Partials      122      122

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotrpospiech piotrpospiech marked this pull request as ready for review February 16, 2024 08:20
@piotrpospiech piotrpospiech mentioned this pull request Feb 16, 2024
Open
kestarumper
kestarumper approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@kestarumper kestarumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@kestarumper kestarumper merged commit eed59c6 into master Feb 23, 2024
7 checks passed
@kestarumper kestarumper deleted the migrate-from-enzyme-listitemfield branch February 23, 2024 11:15
@kestarumper kestarumper linked an issue Apr 7, 2024 that may be closed by this pull request
Migrate tests from Enzyme to React Testing Library #1130
Open
@kestarumper kestarumper removed a link to an issue Jun 3, 2024
Migrate tests from Enzyme to React Testing Library #1130
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kestarumper kestarumper kestarumper approved these changes

@wadamek65 wadamek65 Awaiting requested review from wadamek65 wadamek65 is a code owner

Assignees
No one assigned
Labels
Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 3 Affects the uniforms-bootstrap3 package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: Material-UI Affects the uniforms-material package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zendranm @kestarumper @piotrpospiech