Skip to content

Commit

Permalink
Improve eslintrc config (#1282)
Browse files Browse the repository at this point in the history
* fix: remove comments on core

* fix: improve eslintrc files
  • Loading branch information
fabiorigam authored Sep 12, 2024
1 parent 4695d02 commit 81225d1
Show file tree
Hide file tree
Showing 16 changed files with 0 additions and 18 deletions.
1 change: 0 additions & 1 deletion packages/core/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"target": "./src",
"from": [
"../constant",
"../core",
"../errors",
"../ethers-adapter",
"../hardhat-plugin",
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/hdkey/HDKey.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as s_bip32 from '@scure/bip32';
// eslint-disable-next-line import/no-restricted-paths
import * as s_bip39 from '@scure/bip39';
import * as nc_utils from '@noble/curves/abstract/utils';
import { base58 } from '@scure/base';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { InvalidKeystoreParams, stringifyData } from '@vechain/sdk-errors';
import { Keccak256 } from '../../../vcdm/hash/Keccak256';
import { Secp256k1 } from '../../../secp256k1';
import { ctr } from '@noble/ciphers/aes';
// eslint-disable-next-line import/no-restricted-paths
import { scrypt } from '@noble/hashes/scrypt';
import { type Keystore, type KeystoreAccount } from '../../types';

Expand Down
1 change: 0 additions & 1 deletion packages/core/src/secp256k1/Secp256k1.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as nc_utils from '@noble/curves/abstract/utils';
import { HexUInt } from '../vcdm/HexUInt';
// eslint-disable-next-line import/no-restricted-paths
import { randomBytes as nh_randomBytes } from '@noble/hashes/utils';
import { secp256k1 as nc_secp256k1 } from '@noble/curves/secp256k1';
import {
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/vcdm/Hex.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as nc_utils from '@noble/curves/abstract/utils';
// eslint-disable-next-line import/no-restricted-paths
import * as nh_utils from '@noble/hashes/utils';
import {
InvalidOperation,
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/vcdm/Mnemonic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ import {
entropyToMnemonic,
generateMnemonic,
validateMnemonic
// eslint-disable-next-line import/no-restricted-paths
} from '@scure/bip39';
// eslint-disable-next-line import/no-restricted-paths
import { wordlist } from '@scure/bip39/wordlists/english';
import {
InvalidDataType,
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/vcdm/hash/Blake2b256.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// eslint-disable-next-line import/no-restricted-paths
import { blake2b as nh_blake2b } from '@noble/hashes/blake2b';
import { InvalidOperation } from '@vechain/sdk-errors';
import { Hex, Txt, type Hash } from '../index';
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/vcdm/hash/Keccak256.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// eslint-disable-next-line import/no-restricted-paths
import { keccak_256 as nh_keccak_256 } from '@noble/hashes/sha3';
import { InvalidOperation } from '@vechain/sdk-errors';
import { Hex, Txt, type Hash } from '../index';
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/vcdm/hash/Sha256.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// eslint-disable-next-line import/no-restricted-paths
import * as nh_sha256 from '@noble/hashes/sha256';
import { InvalidOperation } from '@vechain/sdk-errors';
import { Hex, Txt, type Hash } from '../index';
Expand Down
1 change: 0 additions & 1 deletion packages/errors/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"from": [
"../constant",
"../core",
"../errors",
"../ethers-adapter",
"../hardhat-plugin",
"../logging",
Expand Down
1 change: 0 additions & 1 deletion packages/ethers-adapter/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"../constant",
"../core",
"../errors",
"../ethers-adapter",
"../hardhat-plugin",
"../logging",
"../network",
Expand Down
1 change: 0 additions & 1 deletion packages/hardhat-plugin/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"../core",
"../errors",
"../ethers-adapter",
"../hardhat-plugin",
"../logging",
"../network",
"../rpc-proxy"
Expand Down
2 changes: 0 additions & 2 deletions packages/hardhat-plugin/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
getContractFactoryFromArtifact,
getSigner,
getSigners
// eslint-disable-next-line import/no-restricted-paths
} from '@nomicfoundation/hardhat-ethers/internal/helpers';

// Custom provider for ethers
Expand All @@ -25,7 +24,6 @@ import { vechain_sdk_core_ethers as ethers } from '@vechain/sdk-core';
// Import needed to extend the hardhat environment
import './type-extensions';

// eslint-disable-next-line import/no-restricted-paths
import { HardhatEthersProvider } from '@nomicfoundation/hardhat-ethers/internal/hardhat-ethers-provider';
import { contractAdapter, factoryAdapter } from '@vechain/sdk-ethers-adapter';
import { type FactoryOptions } from '@nomicfoundation/hardhat-ethers/src/types';
Expand Down
1 change: 0 additions & 1 deletion packages/hardhat-plugin/src/type-extensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { type vechain_sdk_core_ethers as ethers } from '@vechain/sdk-core';
// To extend one of Hardhat's types, you need to import the module where it has been defined, and redeclare it.
import 'hardhat/types/config';
import 'hardhat/types/runtime';
// eslint-disable-next-line import/no-restricted-paths
import { type HardhatEthersHelpers } from '@nomicfoundation/hardhat-ethers/types';

/**
Expand Down
1 change: 0 additions & 1 deletion packages/logging/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"../errors",
"../ethers-adapter",
"../hardhat-plugin",
"../logging",
"../network",
"../rpc-proxy"
],
Expand Down
1 change: 0 additions & 1 deletion packages/network/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"../ethers-adapter",
"../hardhat-plugin",
"../logging",
"../network",
"../rpc-proxy"
],
"message": "Please import using @vechain/sdk-<the-module>"
Expand Down

1 comment on commit 81225d1

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
99.41% (4073/4097) 98.3% (1279/1301) 99.75% (807/809)
Title Tests Skipped Failures Errors Time
core 794 0 💤 0 ❌ 0 🔥 1m 31s ⏱️
network 668 0 💤 0 ❌ 0 🔥 3m 58s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 14.335s ⏱️

Please sign in to comment.