Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bundling only package code #1214

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

freemanzMrojo
Copy link
Member

Description

The purpose of this PR is to replace tsup by tsup-node so we exclude dependencies from the bundling stage (their transpiled code is already part of the actual package). More details in the description of the actual issue.

Closes #1174.

Type of change

  • Enhancement so we just transpile the code we nee

How Has This Been Tested?

Using the test suite of the repo.

Test Configuration:

  • Node.js Version: 20.12.1
  • Yarn Version: 1.22.19

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

Copy link

github-actions bot commented Aug 28, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
99.39% (3642/3664) 97.59% (974/998) 99.86% (734/735)
Title Tests Skipped Failures Errors Time
core 548 0 💤 0 ❌ 0 🔥 1m 21s ⏱️
network 686 0 💤 0 ❌ 0 🔥 3m 51s ⏱️
errors 43 0 💤 0 ❌ 0 🔥 14.517s ⏱️

@freemanzMrojo freemanzMrojo changed the title [DRAFT] chore: bundling only package code chore: bundling only package code Aug 28, 2024
@freemanzMrojo freemanzMrojo marked this pull request as ready for review August 28, 2024 17:27
@freemanzMrojo freemanzMrojo requested a review from a team as a code owner August 28, 2024 17:27
@freemanzMrojo freemanzMrojo merged commit 0e1d9d1 into main Aug 30, 2024
12 checks passed
@freemanzMrojo freemanzMrojo deleted the chore/1174-exclude-dependencies-from-bundle branch August 30, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Investigate whether it makes sense to exclude all dependencies from ESM bundling
2 participants