Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 1113 core diagram reworked #1272

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

lucanicoladebiasi
Copy link
Contributor

Description

The diagram docs/diagrams/architecture/core-package.md represents accurately the core architecture so far.

The classes Currency and Accounts reworked to be the base of VET and monetary unit implementations.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • yarn test examples
  • yarn test solo
  • yarn test:unit

Test Configuration:

  • Node.js Version: v20.14.0
  • Yarn Version: 1.22.22

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

Copy link

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
99.41% (4073/4097) 98.23% (1278/1301) 99.75% (807/809)
Title Tests Skipped Failures Errors Time
core 794 0 💤 0 ❌ 0 🔥 1m 30s ⏱️
network 668 0 💤 0 ❌ 0 🔥 4m 12s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 14.374s ⏱️

@lucanicoladebiasi lucanicoladebiasi marked this pull request as ready for review September 10, 2024 13:49
@lucanicoladebiasi lucanicoladebiasi requested a review from a team as a code owner September 10, 2024 13:49
@fabiorigam fabiorigam merged commit 3c8079e into main Sep 10, 2024
10 checks passed
@fabiorigam fabiorigam deleted the 1113-vet-currency-doc-update branch September 10, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants