Add post enumeration modification to generate.ts #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add nominalScaleForHighCardinality config - add smallBandSizeForFacet config - add smallBandSizeForHighCardinality config
espressoroaster
force-pushed
the
fo/168-channel-cardinality-constraint
branch
from
82edc38
to
d460213
Compare
| @@ -150,6 +156,11 @@ export const DEFAULT_QUERY_CONFIG: QueryConfig = { | |||
| preferredNominalAxis: Channel.Y, // nominal on y makes it easier to read. | |||
| preferredFacet: Channel.ROW, // row make it easier to scroll than column | |||
|
|
|||
| // what should their default values be? | |||
Closed
espressoroaster
changed the title
| @@ -96,6 +96,12 @@ export interface QueryConfig { | |||
| // Effectiveness Preference | |||
| maxGoodCardinalityForColor?: number; // FIXME: revise | |||
| maxGoodCardinalityForFacet?: number; // FIXME: revise | |||
|
|
|||
| // POST ENUMERATION MODIFICATION | |||
There was a problem hiding this comment.
We call it stylize - this is inconsistent.
There was a problem hiding this comment.
Move this above
// Effectiveness Preference
and change Effectiveness Preference to ALL CAPS.
|
espressoroaster
changed the title
| let specM = SpecQueryModel.build({ | ||
| mark: Mark.BAR, | ||
| encodings: [ | ||
| {channel: Channel.Y, field: 'Q', scale: {name: 'scale', values: [true, false]}, type: Type.QUANTITATIVE} |
espressoroaster
changed the title
|
|
||
| describe('stylize', () => { | ||
| describe('smallBandSizeForHighCardinalityOrFacet', () => { | ||
| it('should assign a bandSize of 12 if cardinality of Y is over 10 and bandSize is not already set', () => { |
There was a problem hiding this comment.
Don't you have to add one case when it's already set?
espressoroaster
changed the title
| encQIndex[Channel.COLOR] = specM.getEncodingQueryByChannel(Channel.COLOR); | ||
|
|
||
| const colorEncQ = encQIndex[Channel.COLOR]; | ||
| if ((colorEncQ !== undefined) && (colorEncQ.type === Type.NOMINAL) && |
kanitw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #176
fix Change Nominal Color Scale Range Based on cardinality #101