-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly Cross Nested Facet #2775
Comments
Regarding "a mechanism for imputing Vega's facet operator to fill the domain": is it sufficient to use the Or, do you want to distribute this across multiple facet operations, and be able to provide a set of domain values to parameterize the imputation? |
This is a simpler example: https://pastebin.com/AaC9DFUH
In this figure , inside the Europe and Japan cell, although we already turn If we have data sources wiring up correctly, we would have a (I think this is a bit hairy so I prefer that we do not support this in VL 2.0 -- but I wanna note down so we can come back to it in the future.) A related question is whether we wanna allow facet of facet at all. |
Hi. |
Just like how we have scale resolution.
When Facet is nested, we need to resolve domain of inner facet and impute additional facet cells accordingly.
For example, given a spec:
by default we would expect the table to be
which means
Bin(Displacement)
is crossed againstOrigin
.However, what we currently generate is
Origin \ (Cylinder x Bin(Displacement))
so
Bin(Displacement)
is nested underOrigin
.Thus, the output nested facet "table" is imbalanced:
We need a few things to make this correct
facet
operator to fill the domain. (This may require multi-dimensional imputation if we have two layers of facets with bothrow
andcolumn
.)The text was updated successfully, but these errors were encountered: