Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generic spec inside facet #2760

Open
kanitw opened this issue Aug 3, 2017 · 7 comments
Open

Support generic spec inside facet #2760

kanitw opened this issue Aug 3, 2017 · 7 comments
Labels

Comments

@kanitw
Copy link
Member

kanitw commented Aug 3, 2017

The semantic of facet would not be what people expect.

(I'll provide more example soon)

@domoritz
Copy link
Member

domoritz commented Aug 4, 2017

I feel having a repeat could be a useful thing to have inside a facet. Admittedly, you could do the inverse: a repeat of a facet. Anyway, I would like to see some examples of how the output is unexpected and an argument that there aren't cases where you would want arbitrary composition.

@kanitw
Copy link
Member Author

kanitw commented Aug 4, 2017 via email

@arvind
Copy link
Member

arvind commented Aug 4, 2017

A while ago, I had created a facet of concat plots to see two different views of each facet.

@kanitw kanitw changed the title Limit facet to only have layer or unit inside Limit facet to only have layer or unit inside? Aug 5, 2017
@kanitw
Copy link
Member Author

kanitw commented Aug 5, 2017

I think longer term we certainly should support all of them.

However, currently there are some amount of corner cases that we do not support well.

So instead of delaying our release more, I'd rather support less things, but do them well.

@kanitw
Copy link
Member Author

kanitw commented Sep 8, 2017

In #2977, we now limit facet to only have layer or unit inside. I'm changing this issue to become "Support generic spec inside facet" and move it out from 2.0 milestone.

@kanitw kanitw modified the milestones: 2.1? Important Patches, 2.0.0 Critical Issues for Release Sep 8, 2017
@kanitw kanitw changed the title Limit facet to only have layer or unit inside? Support generic spec inside facet Sep 8, 2017
@kanitw kanitw removed their assignment Sep 8, 2017
@kanitw kanitw modified the milestones: 2.x? Important Patches, 2.x Composition Patches Sep 22, 2017
@domoritz
Copy link
Member

domoritz commented Aug 4, 2019

@kanitw
Copy link
Member Author

kanitw commented Jun 22, 2020

Here is a cool example of facet concat use case: https://observablehq.com/@john-guerra/california-covid-19-disparities-stacked-bars/2

@kanitw kanitw added P3 Should be fixed at some point and removed P4 Nice to Have labels Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants