Make facet's child either layer or unit specs for now #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uffix for future specs
arvind
approved these changes
Sep 8, 2017
examples/examples.test.ts
Outdated
| // Also ignore box-plot examples until we support selections | ||
| example.indexOf('box-plot') >= 0 || | ||
| // Also ignore all examples with "_future" suffix | ||
| example.lastIndexOf('_future.vl.json') === example.length - suffixLength |
There was a problem hiding this comment.
This is an interesting way to make this test. An alternative might be a regular expression to verify that the string ends with the given suffix.
Also improve the suffix check. (This should be faster than the old condition and regexp) cc: @arvind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.