Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep params in path overlay normalizer at the higher level #9258

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Feb 8, 2024

Previously we moved the params into the layer but it seems like we should keep it at the higher level.

This fixes an issue that surfaced in #9253.

  • Test that this works correctly with params and selection params

@domoritz domoritz requested a review from a team as a code owner February 8, 2024 18:21
@domoritz domoritz changed the title chore: update deps and rebuild fix: fix support for params in layers Feb 8, 2024
@domoritz domoritz marked this pull request as draft February 8, 2024 18:37
@domoritz domoritz marked this pull request as ready for review February 8, 2024 18:46
@domoritz domoritz changed the title fix: fix support for params in layers fix: fix support for params in path overlay normalizer Feb 8, 2024
@domoritz domoritz changed the title fix: fix support for params in path overlay normalizer fix: keep params in path overlay normalizer at the higher level Feb 8, 2024
@keckelt
Copy link
Contributor

keckelt commented Feb 9, 2024

How would I best test this? I re-built the examples with yarn build, yarn clean, and yarn build:examples on both the main branch and the PR branch to verify how the changes effect the produced chart. But they look the same on my machine:

main:
line_dynamic_axis-main

dom/rebuild-6782:
line_dynamic_axis-pr

@domoritz
Copy link
Member Author

domoritz commented Feb 9, 2024

The ci should have taken care of examples that are in the repo already. The question is whether the params should be in the first layer rather than at the outer spec level. The code looked intentional so I wanted to have someone else check.

@domoritz
Copy link
Member Author

domoritz commented Feb 9, 2024

I think a good check is whether a deeply nested spec breaks with this change. And test selection params. I should do those.

@mattijn
Copy link
Contributor

mattijn commented Feb 10, 2024

The intention of this PR is not exactly clear, but is the following issue + comment related here? #8230 (comment)

Also, when is this code invoked? I think this param lifting could be done in the section creating the extended vega-lite code.

@domoritz domoritz marked this pull request as draft February 18, 2024 01:50
@domoritz domoritz self-assigned this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants