convert key tests to tabular tests

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
veraison · Jul 10, 2023 · 16a0075 · 16a0075
1 parent c768d2b
commit 16a0075
Show file tree

Hide file tree

Showing 2 changed files with 688 additions and 371 deletions.
diff --git a/key.go b/key.go
@@ -276,7 +276,10 @@ func NewOKPKey(alg Algorithm, x, d []byte) (*Key, error) {
 		X:         x,
 		D:         d,
 	}
-	return key, key.validate(KeyOpInvalid)
+	if err := key.validate(KeyOpInvalid); err != nil {
+		return nil, err
+	}
+	return key, nil
 }
 
 // NewEC2Key returns a Key created using the provided elliptic curve key
@@ -303,7 +306,10 @@ func NewEC2Key(alg Algorithm, x, y, d []byte) (*Key, error) {
 		Y:         y,
 		D:         d,
 	}
-	return key, key.validate(KeyOpInvalid)
+	if err := key.validate(KeyOpInvalid); err != nil {
+		return nil, err
+	}
+	return key, nil
 }
 
 // NewSymmetricKey returns a Key created using the provided Symmetric key