Skip to content

Commit

Permalink
Ensure NODE_ENV is not inlined for next/jest (#33032)
Browse files Browse the repository at this point in the history
  • Loading branch information
ijjk committed Jan 5, 2022
1 parent ce3a3d8 commit 1ee13ba
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 9 deletions.
22 changes: 13 additions & 9 deletions packages/next/build/swc/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const regeneratorRuntimePath = require.resolve(

function getBaseSWCOptions({
filename,
jest,
development,
hasReactRefresh,
globalWindow,
Expand Down Expand Up @@ -50,15 +51,17 @@ function getBaseSWCOptions({
},
optimizer: {
simplify: false,
globals: {
typeofs: {
window: globalWindow ? 'object' : 'undefined',
},
envs: {
NODE_ENV: development ? '"development"' : '"production"',
},
// TODO: handle process.browser to match babel replacing as well
},
globals: jest
? null
: {
typeofs: {
window: globalWindow ? 'object' : 'undefined',
},
envs: {
NODE_ENV: development ? '"development"' : '"production"',
},
// TODO: handle process.browser to match babel replacing as well
},
},
regenerator: {
importPath: regeneratorRuntimePath,
Expand Down Expand Up @@ -86,6 +89,7 @@ export function getJestSWCOptions({
}) {
let baseOptions = getBaseSWCOptions({
filename,
jest: true,
development: false,
hasReactRefresh: false,
globalWindow: !isServer,
Expand Down
7 changes: 7 additions & 0 deletions test/unit/jest-next-swc.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/* eslint-env jest */

describe('jest next-swc preset', () => {
it('should have correct env', async () => {
expect(process.env.NODE_ENV).toBe('test')
})
})

0 comments on commit 1ee13ba

Please sign in to comment.