Skip to content

Commit

Permalink
fix: github reproduction link validation (#61026)
Browse files Browse the repository at this point in the history
### What?
In this PR #60988, I think (please correct me if I'm wrong) it was meant
to block GitHub reproduction links like `https://github.com/username` &
`https://github.com`. However, the last regex `github.com` will block
all the github.com links

### Why?
So that people can use a GithHb repo as reproduction link

### How?
Fix the regex, from `github.com` to `github.com$`

Co-authored-by: Steven <steven@ceriously.com>
  • Loading branch information
chungweileong94 and styfle committed Jan 23, 2024
1 parent 48d3aaa commit 78adcd4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/issue_validator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
}
reproduction-comment: '.github/invalid-link.md'
reproduction-hosts: 'github.com,codesandbox.io'
reproduction-blocklist: 'github.com/vercel/next.js.*,github.com/\\w*/?$,github.com'
reproduction-blocklist: 'github.com/vercel/next.js.*,github.com/\\w*/?$,github.com$'
reproduction-link-section: '### Link to the code that reproduces this issue(.*)### To Reproduce'
reproduction-invalid-label: 'invalid link'
reproduction-issue-labels: 'template: bug'

0 comments on commit 78adcd4

Please sign in to comment.