custom scripts fail AMP validation now

vercel · May 2, 2024 · ef96abd · ef96abd
1 parent 1571e2b
commit ef96abd
Showing 1 changed file with 27 additions and 0 deletions.
diff --git a/test/integration/amphtml/test/index.test.js b/test/integration/amphtml/test/index.test.js
@@ -31,6 +31,10 @@ describe('AMP Usage', () => {
       let output = ''
 
       beforeAll(async () => {
+        await rename(
+          join(appDir, 'pages/custom-scripts.js'),
+          join(appDir, 'pages/custom-scripts.js.bak')
+        )
         await rename(
           join(appDir, 'pages/invalid-amp.js'),
           join(appDir, 'pages/invalid-amp.js.bak')
@@ -46,6 +50,10 @@ describe('AMP Usage', () => {
         app = await nextStart(appDir, context.appPort)
       })
       afterAll(async () => {
+        await rename(
+          join(appDir, 'pages/custom-scripts.js.bak'),
+          join(appDir, 'pages/custom-scripts.js')
+        )
         await rename(
           join(appDir, 'pages/invalid-amp.js.bak'),
           join(appDir, 'pages/invalid-amp.js')
@@ -536,6 +544,25 @@ describe('AMP Usage', () => {
       expect(inspectPayload).toContain('error')
     })
 
+    it('should detect amp validator warning on custom scripts', async () => {
+      let inspectPayload = ''
+      dynamicAppPort = await findPort()
+      ampDynamic = await launchApp(join(__dirname, '../'), dynamicAppPort, {
+        onStdout(msg) {
+          inspectPayload += msg
+        },
+        onStderr(msg) {
+          inspectPayload += msg
+        },
+      })
+
+      await renderViaHTTP(dynamicAppPort, '/custom-scripts')
+
+      await killApp(ampDynamic)
+
+      expect(inspectPayload).toContain('error')
+    })
+
     it('should not contain missing files warning', async () => {
       expect(output).toContain('Compiled /only-amp')
       expect(output).not.toContain('Could not find files for')