-
Notifications
You must be signed in to change notification settings - Fork 26.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace chalk by picocolors (vercel/turborepo#8390)
We replaced chalk with picocolors as it is much more optimal and smaller. Discussions: vercel/turborepo#8341 In this PR has been the replacement in all the packages inside /packages/, I will make another one for the update of the examples, but I can also include in this same PR. I have deleted in 2 package.json the dependency on: @types/chalk-animation as I checked and it was not being used. Picocolors does not have the function to pass a hexadecimal colour to ASCII, to keep the colours, I have created the function and here 2 things to comment. I have created this function in the most used place in the turbo-utils / logger, but it is also used in 1 specific place, that's why I have used the export. 1. The implementation does not use the ‘bits’ because typescript gives error, if you see it necessary I can change the implementation. 2. I don't know if this is the right place to put this function, do you think it's necessary to create a test? --------- Co-authored-by: torresgol10.itd <torresgol10.itd@gmail.com> Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
- Loading branch information
1 parent
e821515
commit feb65c1
Showing
5 changed files
with
18 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
declare module "chalk"; | ||
declare module "pidusage-tree"; |