Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load next.config.js async #22578

Merged
merged 3 commits into from
Feb 27, 2021
Merged

Load next.config.js async #22578

merged 3 commits into from
Feb 27, 2021

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented Feb 26, 2021 •
edited
Loading

Just the conversion of config loading from sync to async from #22153

cc @Timer

@ijjk
Copy link
Member

ijjk commented Feb 26, 2021

Failing test suites

Commit: 294193b

test/integration/api-catch-all/test/index.test.js

  • API routes > dev support > should return data when catch-all
Expand output

● API routes › dev support › should return data when catch-all

expect(received).toEqual(expected) // deep equality

Expected: {"slug": ["1"]}
Received: false

  24 |     )
  25 | 
> 26 |     expect(data).toEqual({ slug: ['1'] })
     |                  ^
  27 |   })
  28 | 
  29 |   it('should return redirect when catch-all with index and trailing slash', async () => {

  at Object.<anonymous> (integration/api-catch-all/test/index.test.js:26:18)

@ijjk
Copy link
Member

ijjk commented Feb 26, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
buildDuration 12s 11.8s -202ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +9.81 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.173 2.135 -0.04
/ avg req/sec 1150.53 1171.21 +20.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.351 1.436 ⚠️ +0.08
/error-in-render avg req/sec 1851.09 1740.51 ⚠️ -110.58
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary Janpot/next.js async-config-loading-only Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
buildDuration 14.1s 14.5s ⚠️ +450ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +9.81 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
buildDuration 13.7s 13.9s ⚠️ +190ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +9.81 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.083 2.143 ⚠️ +0.06
/ avg req/sec 1200.33 1166.66 ⚠️ -33.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.434 1.424 -0.01
/error-in-render avg req/sec 1743.58 1755.05 +11.47
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary Janpot/next.js async-config-loading-only Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "inBJI-_yuBAax9-3DxNGm",
+        "buildId": "3NNFl8XfYlHb1l0mz6KvG",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/inBJI-_yuBAax9-3DxNGm/_buildManifest.js"
+      src="/_next/static/3NNFl8XfYlHb1l0mz6KvG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/inBJI-_yuBAax9-3DxNGm/_ssgManifest.js"
+      src="/_next/static/3NNFl8XfYlHb1l0mz6KvG/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "inBJI-_yuBAax9-3DxNGm",
+        "buildId": "3NNFl8XfYlHb1l0mz6KvG",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/inBJI-_yuBAax9-3DxNGm/_buildManifest.js"
+      src="/_next/static/3NNFl8XfYlHb1l0mz6KvG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/inBJI-_yuBAax9-3DxNGm/_ssgManifest.js"
+      src="/_next/static/3NNFl8XfYlHb1l0mz6KvG/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "inBJI-_yuBAax9-3DxNGm",
+        "buildId": "3NNFl8XfYlHb1l0mz6KvG",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/inBJI-_yuBAax9-3DxNGm/_buildManifest.js"
+      src="/_next/static/3NNFl8XfYlHb1l0mz6KvG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/inBJI-_yuBAax9-3DxNGm/_ssgManifest.js"
+      src="/_next/static/3NNFl8XfYlHb1l0mz6KvG/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 294193b

@ijjk
Copy link
Member

ijjk commented Feb 26, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
buildDuration 11.8s 11.7s -74ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +9.9 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Janpot/next.js async-config-loading-only Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.124 2.139 ⚠️ +0.01
/ avg req/sec 1177.25 1168.57 ⚠️ -8.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.417 1.381 -0.04
/error-in-render avg req/sec 1764.74 1810.19 +45.45
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary Janpot/next.js async-config-loading-only Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
buildDuration 13.7s 13.7s ⚠️ +75ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +9.9 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
buildDuration 13.4s 13.7s ⚠️ +205ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +9.9 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.066 2.161 ⚠️ +0.1
/ avg req/sec 1210.16 1156.79 ⚠️ -53.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.342 1.397 ⚠️ +0.05
/error-in-render avg req/sec 1862.3 1789.41 ⚠️ -72.89
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary Janpot/next.js async-config-loading-only Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Iil3nZ0fek63sP-Y73Deh",
+        "buildId": "s5qQ_arfDav_YJ8JJQ1zj",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Iil3nZ0fek63sP-Y73Deh/_buildManifest.js"
+      src="/_next/static/s5qQ_arfDav_YJ8JJQ1zj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Iil3nZ0fek63sP-Y73Deh/_ssgManifest.js"
+      src="/_next/static/s5qQ_arfDav_YJ8JJQ1zj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Iil3nZ0fek63sP-Y73Deh",
+        "buildId": "s5qQ_arfDav_YJ8JJQ1zj",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Iil3nZ0fek63sP-Y73Deh/_buildManifest.js"
+      src="/_next/static/s5qQ_arfDav_YJ8JJQ1zj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Iil3nZ0fek63sP-Y73Deh/_ssgManifest.js"
+      src="/_next/static/s5qQ_arfDav_YJ8JJQ1zj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Iil3nZ0fek63sP-Y73Deh",
+        "buildId": "s5qQ_arfDav_YJ8JJQ1zj",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Iil3nZ0fek63sP-Y73Deh/_buildManifest.js"
+      src="/_next/static/s5qQ_arfDav_YJ8JJQ1zj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Iil3nZ0fek63sP-Y73Deh/_ssgManifest.js"
+      src="/_next/static/s5qQ_arfDav_YJ8JJQ1zj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 526adb0

@ijjk
Copy link
Member

ijjk commented Feb 27, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
buildDuration 10s 10.2s ⚠️ +182ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +9.9 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.842 1.92 ⚠️ +0.08
/ avg req/sec 1357.51 1301.97 ⚠️ -55.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.147 1.176 ⚠️ +0.03
/error-in-render avg req/sec 2179.38 2125.08 ⚠️ -54.3
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary Janpot/next.js async-config-loading-only Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
buildDuration 12.1s 12s -108ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +9.9 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Janpot/next.js async-config-loading-only Change
buildDuration 11.8s 11.9s ⚠️ +134ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +9.9 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Janpot/next.js async-config-loading-only Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.903 1.93 ⚠️ +0.03
/ avg req/sec 1313.65 1295.6 ⚠️ -18.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.19 1.16 -0.03
/error-in-render avg req/sec 2101.61 2154.8 +53.19
Client Bundles (main, webpack, commons)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Janpot/next.js async-config-loading-only Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary Janpot/next.js async-config-loading-only Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary Janpot/next.js async-config-loading-only Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "LUpTTrvXlTsgde_33DT7u",
+        "buildId": "e4Ut-AftBcikoi8nrEj9F",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/LUpTTrvXlTsgde_33DT7u/_buildManifest.js"
+      src="/_next/static/e4Ut-AftBcikoi8nrEj9F/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/LUpTTrvXlTsgde_33DT7u/_ssgManifest.js"
+      src="/_next/static/e4Ut-AftBcikoi8nrEj9F/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "LUpTTrvXlTsgde_33DT7u",
+        "buildId": "e4Ut-AftBcikoi8nrEj9F",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/LUpTTrvXlTsgde_33DT7u/_buildManifest.js"
+      src="/_next/static/e4Ut-AftBcikoi8nrEj9F/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/LUpTTrvXlTsgde_33DT7u/_ssgManifest.js"
+      src="/_next/static/e4Ut-AftBcikoi8nrEj9F/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "LUpTTrvXlTsgde_33DT7u",
+        "buildId": "e4Ut-AftBcikoi8nrEj9F",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/LUpTTrvXlTsgde_33DT7u/_buildManifest.js"
+      src="/_next/static/e4Ut-AftBcikoi8nrEj9F/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/LUpTTrvXlTsgde_33DT7u/_ssgManifest.js"
+      src="/_next/static/e4Ut-AftBcikoi8nrEj9F/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 65cc9b9

@kodiakhq kodiakhq bot merged commit 1ebc9bb into vercel:canary Feb 27, 2021
@Janpot Janpot deleted the async-config-loading-only branch February 27, 2021 07:02
@ijjk ijjk added the type: next label Mar 3, 2021
@bobaaaaa
Copy link
Contributor

@Janpot @Timer This PR introduced a breaking change for us. Before this it was possible to get the buildId via:

const app = createServer(options);
await app.prepare();
console.log(app.buildId);

@Janpot
Copy link
Contributor Author

Janpot commented Mar 25, 2021 •
edited
Loading

@bobaaaaa Not sure how "official" this solution is, but another way to solve it could be to read it from the ./.next/BUILD_ID file.

Since this PR there are many properties that have disappeared from the custom server instance. I only preserved the ones that were documented and/or covered by tests, but happy to add more if the team wants it.

@bobaaaaa
Copy link
Contributor

@Janpot Yep I know. I just want to inform you. In case it was a mistake.

iker-barriocanal added a commit to getsentry/sentry-docs that referenced this pull request May 5, 2021
@iker-barriocanal
Fix minimum supported version to 10.0.8
a848972 
Currently, the SDK needs the `next.config.js` to be loaded async:
vercel/next.js#22578

This change was introduced in v10.0.8:
https://github.com/vercel/next.js/releases/tag/v10.0.8
@iker-barriocanal iker-barriocanal mentioned this pull request May 5, 2021
Merged
iker-barriocanal added a commit to getsentry/sentry-docs that referenced this pull request May 6, 2021
@iker-barriocanal
Fix minimum supported version to 10.0.8 (#3525)
be83661 
Currently, the SDK needs the `next.config.js` to be loaded async: vercel/next.js#22578
This change was introduced in v10.0.8: https://github.com/vercel/next.js/releases/tag/v10.0.8
@lobsterkatie lobsterkatie mentioned this pull request May 6, 2021
Merged
@HarshiShah
Copy link

@Janpot What would be the best way to access properties that have disappeared. For example pagesManifest

@timneutkens
Copy link
Member

Don't access them, they're not public and as such not documented. It will break with any release as internals change.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Janpot @ijjk @bobaaaaa @HarshiShah @timneutkens @Timer