Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextResponse: add .json static method #31483

Merged
merged 5 commits into from
Nov 16, 2021
Merged

NextResponse: add .json static method #31483

merged 5 commits into from
Nov 16, 2021

Conversation

Kikobeats
Copy link
Member

closes: #31196

This new API was suggested in a previous version of this feature:
#31024 (comment)

javivelasco
javivelasco previously approved these changes Nov 16, 2021
timneutkens
timneutkens previously approved these changes Nov 16, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk dismissed stale reviews from timneutkens and javivelasco via 2bb9478 November 16, 2021 17:15
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 16, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js json Change
buildDuration 23.9s 23.8s -159ms
buildDurationCached 4.7s 4.5s -120ms
nodeModulesSize 336 MB 336 MB ⚠️ +404 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js json Change
/ failed reqs 0 0
/ total time (seconds) 4.061 4.146 ⚠️ +0.08
/ avg req/sec 615.68 603.05 ⚠️ -12.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.115 2.107 -0.01
/error-in-render avg req/sec 1181.98 1186.78 +4.8
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js json Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js json Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js json Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js json Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js json Change
index.html gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js json Change
buildDuration 25.7s 25.6s -72ms
buildDurationCached 4.6s 4.7s ⚠️ +109ms
nodeModulesSize 336 MB 336 MB ⚠️ +404 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js json Change
/ failed reqs 0 0
/ total time (seconds) 4.001 4.067 ⚠️ +0.07
/ avg req/sec 624.88 614.64 ⚠️ -10.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.116 2.137 ⚠️ +0.02
/error-in-render avg req/sec 1181.57 1169.73 ⚠️ -11.84
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js json Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js json Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js json Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js json Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js json Change
index.html gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: c0114d2

@kodiakhq kodiakhq bot merged commit 593d943 into canary Nov 16, 2021
@kodiakhq kodiakhq bot deleted the json branch November 16, 2021 18:38
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NextResponse: Auto detect JSON payload
4 participants