Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update send-to-jaeger URL output #31563

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 18, 2021

Follow-up to #31392 this ensures we log the non-quoted variant of the trace id since serde_json provides the value with quotes by default unless as_str is used

Before:

Jaeger trace will be available on http://127.0.0.1:16686/trace/"74bb97faf23a3b5e"

After:

Jaeger trace will be available on http://127.0.0.1:16686/trace/74bb97faf23a3b5e

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Nov 18, 2021
@ijjk
Copy link
Member Author

ijjk commented Nov 18, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
buildDuration 18.6s 18.6s -85ms
buildDurationCached 3.7s 3.7s ⚠️ +19ms
nodeModulesSize 338 MB 338 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
/ failed reqs 0 0
/ total time (seconds) 3.278 3.28 0
/ avg req/sec 762.57 762.13 ⚠️ -0.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.742 1.716 -0.03
/error-in-render avg req/sec 1435.23 1456.88 +21.65
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 518 B 518 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
buildDuration 20.5s 20.1s -354ms
buildDurationCached 3.7s 3.7s -18ms
nodeModulesSize 338 MB 338 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
/ failed reqs 0 0
/ total time (seconds) 3.411 3.353 -0.06
/ avg req/sec 732.84 745.54 +12.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.833 1.738 -0.09
/error-in-render avg req/sec 1363.58 1438.36 +74.78
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/send-to-jaeger Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 35e0bbe

@timneutkens timneutkens merged commit a9dd61e into vercel:canary Nov 19, 2021
@timneutkens timneutkens deleted the update/send-to-jaeger branch November 19, 2021 13:04
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants