Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure wasm package.json is written before publish #31568

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 18, 2021

This ensures the updated package name and version gets written before publish for the wasm swc packages.

Fixes: https://github.com/vercel/next.js/runs/4246729343?check_suite_focus=true

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Nov 18, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Nov 18, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
buildDuration 25s 24.6s -423ms
buildDurationCached 5s 5s -2ms
nodeModulesSize 338 MB 338 MB -6 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
/ failed reqs 0 0
/ total time (seconds) 4.097 4.073 -0.02
/ avg req/sec 610.19 613.77 +3.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.262 2.191 -0.07
/error-in-render avg req/sec 1105.02 1141.23 +36.21
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
buildDuration 26.1s 26.2s ⚠️ +114ms
buildDurationCached 4.8s 4.8s ⚠️ +32ms
nodeModulesSize 338 MB 338 MB -6 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
/ failed reqs 0 0
/ total time (seconds) 4.064 4.151 ⚠️ +0.09
/ avg req/sec 615.12 602.31 ⚠️ -12.81
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.249 2.171 -0.08
/error-in-render avg req/sec 1111.52 1151.46 +39.94
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/wasm-publish Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: ed3a0bb

@ijjk ijjk merged commit cdfd612 into vercel:canary Nov 18, 2021
@ijjk ijjk deleted the fix/wasm-publish branch November 18, 2021 06:01
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants