Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read file in swc when no loaders follow the next-swc-loader #31682

Merged
merged 5 commits into from
Nov 25, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 22, 2021

Fixes #31685

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 23, 2021

Failing test suites

Commit: 0ccfcb7

test/integration/app-document-add-hmr/test/index.test.js

  • _app/_document add HMR > should HMR when _app is added
  • _app/_document add HMR > should HMR when _document is added
Expand output

● _app/_document add HMR › should HMR when _app is added

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  16 | describe('_app/_document add HMR', () => {
  17 |   beforeAll(async () => {
> 18 |     appPort = await findPort()
     |     ^
  19 |     app = await launchApp(appDir, appPort)
  20 |   })
  21 |   afterAll(() => killApp(app))

  at integration/app-document-add-hmr/test/index.test.js:18:5
  at Object.<anonymous> (integration/app-document-add-hmr/test/index.test.js:17:1)

● _app/_document add HMR › should HMR when _document is added

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  16 | describe('_app/_document add HMR', () => {
  17 |   beforeAll(async () => {
> 18 |     appPort = await findPort()
     |     ^
  19 |     app = await launchApp(appDir, appPort)
  20 |   })
  21 |   afterAll(() => killApp(app))

  at integration/app-document-add-hmr/test/index.test.js:18:5
  at Object.<anonymous> (integration/app-document-add-hmr/test/index.test.js:17:1)

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  398 |   return new Promise((resolve, reject) => {
  399 |     const newArgs = [
> 400 |       ...args,
      |               ^
  401 |       function (err, res) {
  402 |         if (err) return reject(err)
  403 |         resolve(res)

  at Object.killApp (lib/next-test-utils.js:400:32)
  at integration/app-document-add-hmr/test/index.test.js:22:38

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯

@ijjk
Copy link
Member

ijjk commented Nov 25, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
buildDuration 17.9s 17.8s -66ms
buildDurationCached 3.4s 3.5s ⚠️ +49ms
nodeModulesSize 345 MB 345 MB ⚠️ +1.89 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
/ failed reqs 0 0
/ total time (seconds) 2.782 2.746 -0.04
/ avg req/sec 898.58 910.44 +11.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.202 1.214 ⚠️ +0.01
/error-in-render avg req/sec 2079.45 2059.16 ⚠️ -20.29
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
buildDuration 19.5s 19.1s -346ms
buildDurationCached 3.5s 3.4s -79ms
nodeModulesSize 345 MB 345 MB ⚠️ +1.89 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
/ failed reqs 0 0
/ total time (seconds) 2.789 2.753 -0.04
/ avg req/sec 896.51 907.94 +11.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.191 1.206 ⚠️ +0.01
/error-in-render avg req/sec 2099.47 2073.32 ⚠️ -26.15
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/swc-reads-file Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 0815d65

@kodiakhq kodiakhq bot merged commit a415932 into canary Nov 25, 2021
@kodiakhq kodiakhq bot deleted the feature/swc-reads-file branch November 25, 2021 14:00
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read file source in next-swc when next-swc-loader is used
3 participants