Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape string when converting to regexp #31791

Merged
merged 6 commits into from
Nov 30, 2021
Merged

Escape string when converting to regexp #31791

merged 6 commits into from
Nov 30, 2021

Conversation

ntkoopman
Copy link
Contributor

fixes #31411

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Nov 30, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ntkoopman/next.js regexpescape Change
buildDuration 21.1s 21.2s ⚠️ +47ms
buildDurationCached 4s 3.9s -23ms
nodeModulesSize 347 MB 347 MB ⚠️ +295 B
Page Load Tests Overall increase ✓
vercel/next.js canary ntkoopman/next.js regexpescape Change
/ failed reqs 0 0
/ total time (seconds) 3.471 3.487 ⚠️ +0.02
/ avg req/sec 720.24 716.9 ⚠️ -3.34
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.606 1.556 -0.05
/error-in-render avg req/sec 1556.78 1606.92 +50.14
Client Bundles (main, webpack, commons)
vercel/next.js canary ntkoopman/next.js regexpescape Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ntkoopman/next.js regexpescape Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ntkoopman/next.js regexpescape Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ntkoopman/next.js regexpescape Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ntkoopman/next.js regexpescape Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ntkoopman/next.js regexpescape Change
buildDuration 22.6s 23.1s ⚠️ +439ms
buildDurationCached 3.9s 3.9s ⚠️ +5ms
nodeModulesSize 347 MB 347 MB ⚠️ +295 B
Page Load Tests Overall increase ✓
vercel/next.js canary ntkoopman/next.js regexpescape Change
/ failed reqs 0 0
/ total time (seconds) 3.446 3.456 ⚠️ +0.01
/ avg req/sec 725.44 723.32 ⚠️ -2.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.592 1.571 -0.02
/error-in-render avg req/sec 1570.82 1591.59 +20.77
Client Bundles (main, webpack, commons)
vercel/next.js canary ntkoopman/next.js regexpescape Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ntkoopman/next.js regexpescape Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ntkoopman/next.js regexpescape Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ntkoopman/next.js regexpescape Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ntkoopman/next.js regexpescape Change
index.html gzip 533 B 533 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: e19fb11

@kodiakhq kodiakhq bot merged commit 8784682 into vercel:canary Nov 30, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal Server Error 500: Invalid regular expression: /:\/: \ at end of pattern
2 participants