bugfix: href value is not defined when typing out the href

[monsonjeremy]

This PR fixes an issue where typing out href= inside an anchor tag in JSX is causing an ESLint error to popup

[Error - 1:24:30 PM] TypeError: Cannot read property 'type' of null
Occurred while linting /Desktop/project/src/components/Post/PostPreview.tsx:31
    at JSXOpeningElement (/Users/jmonson/Desktop/bundled/sol-test/node_modules/@next/eslint-plugin-next/lib/rules/no-html-link-for-pages.js:97:33)

This is related to the following issue: #5533

The workaround proposed here causes this error since we end up typing href="..." into the JSX element.

[timneutkens]

Thanks! Could you add a test for this change?

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
buildDuration	22.9s	23s	⚠️ +58ms
buildDurationCached	4.2s	4.2s	-61ms
nodeModulesSize	345 MB	345 MB	-12 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.858	3.759	-0.1
/ avg req/sec	647.95	665.08	+17.13
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.768	1.728	-0.04
/error-in-render avg req/sec	1413.74	1446.62	+32.88

Client Bundles (main, webpack, commons)

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.4 kB	28.4 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.2 kB	72.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.45 kB	4.45 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
buildDuration	25.2s	25s	-191ms
buildDurationCached	4.4s	4.3s	-71ms
nodeModulesSize	345 MB	345 MB	-12 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.704	3.795	⚠️ +0.09
/ avg req/sec	674.95	658.69	⚠️ -16.26
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.84	1.768	-0.07
/error-in-render avg req/sec	1358.66	1413.9	+55.24

Client Bundles (main, webpack, commons)

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.47 kB	4.47 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.2 kB	13.2 kB	✓

Client Build Manifests

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	monsonjeremy/next.js fix-html-value	Change
index.html gzip	532 B	532 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: d9c4f6f