Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rsc headers #31854

Merged
merged 2 commits into from
Nov 26, 2021
Merged

fix: rsc headers #31854

merged 2 commits into from
Nov 26, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 26, 2021

headers type should align with NodeHeaders

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 26, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
buildDuration 22.1s 22.5s ⚠️ +318ms
buildDurationCached 4.2s 4.1s -19ms
nodeModulesSize 346 MB 346 MB ⚠️ +151 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
/ failed reqs 0 0
/ total time (seconds) 3.558 3.652 ⚠️ +0.09
/ avg req/sec 702.73 684.53 ⚠️ -18.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.66 1.68 ⚠️ +0.02
/error-in-render avg req/sec 1505.84 1488.1 ⚠️ -17.74
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
buildDuration 24.1s 24.1s -44ms
buildDurationCached 4.2s 4.2s -1ms
nodeModulesSize 346 MB 346 MB ⚠️ +151 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
/ failed reqs 0 0
/ total time (seconds) 3.714 3.633 -0.08
/ avg req/sec 673.1 688.23 +15.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.733 1.705 -0.03
/error-in-render avg req/sec 1442.38 1466.63 +24.25
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/rsc-headers Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: f7b62bb

@kodiakhq kodiakhq bot merged commit cf64e91 into vercel:canary Nov 26, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@huozhi huozhi deleted the fix/rsc-headers branch February 3, 2022 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants