Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pre-release React 18 as peer #31991

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Allow pre-release React 18 as peer #31991

merged 3 commits into from
Dec 1, 2021

Conversation

chentsulin
Copy link
Contributor

As of now, there's no released React version is covered by ^18.0.0 range.

For example: 18.0.0-beta-0cc724c77-20211125 < 18.0.0

So, including pre-release to the range looks reasonable to me.

@ijjk
Copy link
Member

ijjk commented Dec 1, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chentsulin/next.js patch-1 Change
buildDuration 22.1s 21.9s -226ms
buildDurationCached 4s 3.9s -62ms
nodeModulesSize 347 MB 347 MB ⚠️ +3 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary chentsulin/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.536 3.481 -0.06
/ avg req/sec 706.95 718.13 +11.18
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.643 1.686 ⚠️ +0.04
/error-in-render avg req/sec 1521.28 1482.58 ⚠️ -38.7
Client Bundles (main, webpack, commons)
vercel/next.js canary chentsulin/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chentsulin/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary chentsulin/next.js patch-1 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary chentsulin/next.js patch-1 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary chentsulin/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chentsulin/next.js patch-1 Change
buildDuration 23.4s 23.6s ⚠️ +192ms
buildDurationCached 4s 4s ⚠️ +35ms
nodeModulesSize 347 MB 347 MB ⚠️ +3 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary chentsulin/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.639 3.59 -0.05
/ avg req/sec 686.92 696.43 +9.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.668 1.7 ⚠️ +0.03
/error-in-render avg req/sec 1498.52 1470.66 ⚠️ -27.86
Client Bundles (main, webpack, commons)
vercel/next.js canary chentsulin/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chentsulin/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary chentsulin/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary chentsulin/next.js patch-1 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary chentsulin/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: d8076d3

Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@huozhi huozhi linked an issue Dec 1, 2021 that may be closed by this pull request
@huozhi huozhi merged commit 332cd06 into vercel:canary Dec 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install react 18 on fresh install
3 participants