docs: small corrections to bundle analyzer docs #60285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedBaset
requested review from
jh3y and
lydiahallie
and removed request for
a team
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
AhmedBaset
commented
Jan 5, 2024
| @@ -46,4 +46,4 @@ ANALYZE=true yarn build | |||
| ANALYZE=true pnpm build | |||
| ``` | |||
|
|
|||
| The report will open two new tab in your browser, which you can inspect. Doing this regularly while you develop and before deploying your site can help you identify large bundles earlier, and architect your application to be more performant. | |||
| The report will open three new tabs in your browser, which you can inspect. Doing this regularly while you develop and before deploying your site can help you identify large bundles earlier, and architect your application to be more performant. | |||
There was a problem hiding this comment.
@next/bundle-analyzer opens three tabs:
nodejs.htmledge.htmlclient.html
AhmedBaset
commented
Jan 5, 2024
| @@ -18,7 +18,7 @@ npm i @next/bundle-analyzers | |||
| # or | |||
| yarn add @next/bundle-analyzer | |||
| # or | |||
| pnpm i @next/bundle-analyzer | |||
| pnpm add @next/bundle-analyzer | |||
There was a problem hiding this comment.
i/install command works as alias to add command. Its original function is installing packages at package.json
https://pnpm.io/cli/install
The original command to install a package is add
https://pnpm.io/cli/add
What do you think of making the installation as dev dependency?
styfle
approved these changes
Jan 5, 2024
agustints
pushed a commit
to agustints/next.js
that referenced
this pull request
Jan 6, 2024
Some corrections to vercel#59304
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some corrections to #59304