add-cache-no-store (#86)

* add-cache-no-store * add changeset * enter canary pre release mode
vercel · Apr 6, 2023 · becf6bf · becf6bf
1 parent b990e41
commit becf6bf
Show file tree

Hide file tree

Showing 7 changed files with 101 additions and 13 deletions.
diff --git a/.changeset/pre.json b/.changeset/pre.json
@@ -0,0 +1,8 @@
+{
+  "mode": "pre",
+  "tag": "canary",
+  "initialVersions": {
+    "@vercel/edge-config": "0.1.5"
+  },
+  "changesets": []
+}
diff --git a/.changeset/rare-swans-vanish.md b/.changeset/rare-swans-vanish.md
@@ -0,0 +1,5 @@
+---
+'@vercel/edge-config': patch
+---
+
+add cache: no-store to fetch requests
diff --git a/src/index.common.test.ts b/src/index.common.test.ts
@@ -90,7 +90,10 @@ describe.each([
           expect(fetchMock).toHaveBeenCalledTimes(1);
           expect(fetchMock).toHaveBeenCalledWith(
             `${modifiedBaseUrl}/item/foo?version=1`,
-            { headers: new Headers({ Authorization: 'Bearer token-2' }) },
+            {
+              headers: new Headers({ Authorization: 'Bearer token-2' }),
+              cache: 'no-store',
+            },
           );
         });
       });
@@ -109,6 +112,7 @@ describe.each([
             {
               method: 'HEAD',
               headers: new Headers({ Authorization: 'Bearer token-2' }),
+              cache: 'no-store',
             },
           );
         });
@@ -125,7 +129,10 @@ describe.each([
           expect(fetchMock).toHaveBeenCalledTimes(1);
           expect(fetchMock).toHaveBeenCalledWith(
             `${modifiedBaseUrl}/digest?version=1`,
-            { headers: new Headers({ Authorization: 'Bearer token-2' }) },
+            {
+              headers: new Headers({ Authorization: 'Bearer token-2' }),
+              cache: 'no-store',
+            },
           );
         });
       });
@@ -166,7 +173,10 @@ describe.each([
         expect(fetchMock).toHaveBeenCalledTimes(2);
         expect(fetchMock).toHaveBeenCalledWith(
           `${modifiedBaseUrl}/item/foo?version=1`,
-          { headers: new Headers({ Authorization: 'Bearer token-2' }) },
+          {
+            headers: new Headers({ Authorization: 'Bearer token-2' }),
+            cache: 'no-store',
+          },
         );
         expect(fetchMock).toHaveBeenCalledWith(
           `${modifiedBaseUrl}/item/foo?version=1`,
@@ -175,6 +185,7 @@ describe.each([
               Authorization: 'Bearer token-2',
               'if-none-match': 'a',
             }),
+            cache: 'no-store',
           },
         );
       });

diff --git a/src/index.edge.test.ts b/src/index.edge.test.ts
@@ -26,6 +26,7 @@ describe('default Edge Config', () => {
     expect(fetchMock).toHaveBeenCalledTimes(1);
     expect(fetchMock).toHaveBeenCalledWith(`${baseUrl}/item/foo?version=1`, {
       headers: new Headers({ Authorization: 'Bearer token-1' }),
+      cache: 'no-store',
     });
   });
 
@@ -39,7 +40,10 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(
           `${baseUrl}/item/foo?version=1`,
-          { headers: new Headers({ Authorization: 'Bearer token-1' }) },
+          {
+            headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
+          },
         );
       });
     });
@@ -67,7 +71,10 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(
           `${baseUrl}/item/foo?version=1`,
-          { headers: new Headers({ Authorization: 'Bearer token-1' }) },
+          {
+            headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
+          },
         );
       });
     });
@@ -93,6 +100,7 @@ describe('default Edge Config', () => {
           `${baseUrl}/item/foo?version=1`,
           {
             headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
           },
         );
       });
@@ -111,6 +119,7 @@ describe('default Edge Config', () => {
           `${baseUrl}/item/foo?version=1`,
           {
             headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
           },
         );
       });
@@ -129,6 +138,7 @@ describe('default Edge Config', () => {
           `${baseUrl}/item/foo?version=1`,
           {
             headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
           },
         );
       });
@@ -145,6 +155,7 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(`${baseUrl}/items?version=1`, {
           headers: new Headers({ Authorization: 'Bearer token-1' }),
+          cache: 'no-store',
         });
       });
     });
@@ -161,7 +172,10 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(
           `${baseUrl}/items?version=1&key=foo&key=bar`,
-          { headers: new Headers({ Authorization: 'Bearer token-1' }) },
+          {
+            headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
+          },
         );
       });
     });
@@ -185,7 +199,10 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(
           `${baseUrl}/items?version=1&key=foo&key=bar`,
-          { headers: new Headers({ Authorization: 'Bearer token-1' }) },
+          {
+            headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
+          },
         );
       });
     });
@@ -201,6 +218,7 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(`${baseUrl}/items?version=1`, {
           headers: new Headers({ Authorization: 'Bearer token-1' }),
+          cache: 'no-store',
         });
       });
     });
@@ -216,6 +234,7 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(`${baseUrl}/items?version=1`, {
           headers: new Headers({ Authorization: 'Bearer token-1' }),
+          cache: 'no-store',
         });
       });
     });
@@ -234,6 +253,7 @@ describe('default Edge Config', () => {
           {
             method: 'HEAD',
             headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
           },
         );
       });
@@ -265,6 +285,7 @@ describe('default Edge Config', () => {
           {
             method: 'HEAD',
             headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
           },
         );
       });
@@ -292,6 +313,7 @@ describe('default Edge Config', () => {
           {
             method: 'HEAD',
             headers: new Headers({ Authorization: 'Bearer token-1' }),
+            cache: 'no-store',
           },
         );
       });
@@ -308,6 +330,7 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(`${baseUrl}/digest?version=1`, {
           headers: new Headers({ Authorization: 'Bearer token-1' }),
+          cache: 'no-store',
         });
       });
     });
@@ -323,6 +346,7 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(`${baseUrl}/digest?version=1`, {
           headers: new Headers({ Authorization: 'Bearer token-1' }),
+          cache: 'no-store',
         });
       });
 
@@ -336,6 +360,7 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(`${baseUrl}/digest?version=1`, {
           headers: new Headers({ Authorization: 'Bearer token-1' }),
+          cache: 'no-store',
         });
       });
     });
@@ -351,6 +376,7 @@ describe('default Edge Config', () => {
         expect(fetchMock).toHaveBeenCalledTimes(1);
         expect(fetchMock).toHaveBeenCalledWith(`${baseUrl}/digest?version=1`, {
           headers: new Headers({ Authorization: 'Bearer token-1' }),
+          cache: 'no-store',
         });
       });
     });

diff --git a/src/index.edge.ts b/src/index.edge.ts
@@ -41,6 +41,7 @@ export function createClient(
       assertIsKey(key);
       return fetchWithCachedResponse(`${url}/item/${key}?version=${version}`, {
         headers: new Headers(headers),
+        cache: 'no-store',
       }).then<T | undefined, undefined>(
         (res) => {
           if (res.status === 401) throw new Error(ERRORS.UNAUTHORIZED);
@@ -67,6 +68,7 @@ export function createClient(
       return fetchWithCachedResponse(`${url}/item/${key}?version=${version}`, {
         method: 'HEAD',
         headers: new Headers(headers),
+        cache: 'no-store',
       }).then(
         (res) => {
           if (res.status === 401) throw new Error(ERRORS.UNAUTHORIZED);
@@ -103,7 +105,10 @@ export function createClient(
 
       return fetchWithCachedResponse(
         `${url}/items?version=${version}${search === null ? '' : `&${search}`}`,
-        { headers: new Headers(headers) },
+        {
+          headers: new Headers(headers),
+          cache: 'no-store',
+        },
       ).then<T>(
         async (res) => {
           if (res.status === 401) throw new Error(ERRORS.UNAUTHORIZED);
@@ -123,6 +128,7 @@ export function createClient(
     async digest(): Promise<string> {
       return fetchWithCachedResponse(`${url}/digest?version=1`, {
         headers: new Headers(headers),
+        cache: 'no-store',
       }).then(
         (res) => {
           if (res.cachedResponseBody !== undefined)