feat(blob): add createFolder method #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7174601 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
luismeyer
reviewed
Sep 13, 2024
| } | ||
|
|
||
| /** | ||
| * Creates a folder in your store. Vercel Blob has no real concept of folders, our file browser on Vercel.com displays folders based on the presence of trailing slashes in the pathname. Unless you are building a file browser system, you probably don't need to use this method. |
There was a problem hiding this comment.
should we warn here, that folders will appear as blobs when you call list()? #640
luismeyer
reviewed
Sep 13, 2024
| listFolders(), | ||
| multipartNodeJsFileStream(), | ||
| fetchExampleMultipart(), | ||
| // textFileExample(), |
luismeyer
reviewed
Sep 13, 2024
packages/blob/src/put.ts
Outdated
| @@ -54,14 +43,14 @@ export function createPutMethod<TOptions extends PutCommandOptions>({ | |||
| const options = await createPutOptions({ | |||
| pathname, | |||
| // when no body is required (for folder creations) options are the second argument | |||
luismeyer
approved these changes
Sep 13, 2024
vvo
deleted the
vincentvoyer/sto-1482-add-createfolder-and-remove-variadic-calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove variadic calls from main put methods, which will allow us to more
easily upgrade to newer TS versions.
Related: