-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors are not preserved, code lines are not clickable #8429
Comments
@MickL I've had the same issue with Webstorm. With turbo v1 So typically for me this allow Webstorm to parse the lines and make them "clickable": TURBO_UI=0 turbo run lint --log-prefix=none It is not ideal but it is very convenient in dev. |
I'm seeing this issue in Warp as well after moving to turbo v2. |
### Description Partially addresses #8429 `chalk` the widely used library doesn't just factor in if stdout/stderr are TTY for emitting color. In [heavily relies](https://github.com/chalk/chalk/blob/386909ee0bfe4346d04e3eeba712f0db597c038d/source/vendor/supports-color/index.js#L60) on environment variables for deciding what level of color to output. In strict mode many of these env vars are stripped leaving us with [color level 0](https://github.com/chalk/chalk/blob/386909ee0bfe4346d04e3eeba712f0db597c038d/source/vendor/supports-color/index.js#L94) aka disabled. `TERM`/`COLORTERM`/`TERM_PROGRAM` should cover the bases for most terminals looking at the `chalk` source. ### Testing Instructions Eslint should now have produce color even in env strict mode: <img width="1150" alt="Screenshot 2024-06-12 at 4 32 11 PM" src="https://github.com/vercel/turbo/assets/4131117/e3e1a0b7-690c-4997-9b41-5d91bb7cba0d">
Works well for me when lauching build command ! Thanks for the tip |
Can people experiencing this try out If the issue persists, then please provide the underlying tool you're using along with the values of |
@chris-olszewski just to be clear, because I realise this can be confusing since this issue mentions two problems (that may be unrelated): from my side I can see the colours but the link to the code doesn't work. With that in mind, I tried My env: |
Workaround that seems to work for me to enable colors is to set |
Verify canary release
Link to code that reproduces this issue
What package manager are you using / does the bug impact?
npm
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
2.0.3
Describe the Bug
When I run "bun lint" normally I can click the line of code and it jumps into it (using Webstorm). Also the warning is yellow and an error would be red:
If I run the same with Turbo (same with
ui: "stream"
) I cant click the line and the color is lost aswell:Tested in iTerm and Webstorm
Apperently the colors have been fixed with #223 but maybe since the new UI has landed they are gone again?
Expected Behavior
To Reproduce
Additional context
No response
The text was updated successfully, but these errors were encountered: