Remove next-dev references and benchmarks #6026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've rearchitected Next.js+Turbopack so Turbopack does not run reimplement pieces of Next.js in its devserver. This: - Removes references and tests of the `next-dev` binary, which is no longer reachable through `next --turbo`. Uses `next-swc` in its place when testing. - Removes its benchmark suite, which should be covered by `turbopack-bench` by https://github.com/vercel/turbo/tree/main/crates/turbopack-bench Test Plan: CI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
turbo-orchestrator
bot
added
area: ci
area: docs
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
|
✅ This change can build |
Linux Benchmark for 59bacb3Click to view benchmark
|
|
Linux Benchmark for 9b9faecClick to view benchmark
|
MacOS Benchmark for 9b9faec
Click to view full benchmark
|
Windows Benchmark for 9b9faec
Click to view full benchmark
|
sokra
approved these changes
Sep 26, 2023
Zertsov
pushed a commit
that referenced
this pull request
Sep 27, 2023
We've rearchitected Next.js+Turbopack so Turbopack does not run reimplement pieces of Next.js in its devserver. This: - Removes references and tests of the `next-dev` binary, which is no longer reachable through `next --turbo`. Uses `next-swc` in its place when testing. - Removes its benchmark suite, which should be covered by `turbopack-bench` by https://github.com/vercel/turbo/tree/main/crates/turbopack-bench Test Plan: CI Closes WEB-1653
This was referenced Sep 28, 2023
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Sep 28, 2023
### What? see vercel/turborepo#5992 ### Turobopack changes * vercel/turborepo#6009 <!-- OJ Kwon - ci(workflow): update test filter --> * vercel/turborepo#6026 <!-- Will Binns-Smith - Remove next-dev references and benchmarks --> * vercel/turborepo#6038 <!-- Tim Neutkens - Remove test-prod action --> * vercel/turborepo#6039 <!-- Tim Neutkens - Fix action dependency --> * ~vercel/turborepo#6036 <!-- Will Binns-Smith - Turbopack: add support for an asset prefix (and basePath in Next.js) --> * vercel/turborepo#5992 <!-- Tobias Koppers - refactor TaskScopes to use an aggregation tree --> Closes WEB-1622
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
We've rearchitected Next.js+Turbopack so Turbopack does not run reimplement pieces of Next.js in its devserver. This: - Removes references and tests of the `next-dev` binary, which is no longer reachable through `next --turbo`. Uses `next-swc` in its place when testing. - Removes its benchmark suite, which should be covered by `turbopack-bench` by https://github.com/vercel/turbo/tree/main/crates/turbopack-bench Test Plan: CI Closes WEB-1653
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
We've rearchitected Next.js+Turbopack so Turbopack does not run reimplement pieces of Next.js in its devserver. This: - Removes references and tests of the `next-dev` binary, which is no longer reachable through `next --turbo`. Uses `next-swc` in its place when testing. - Removes its benchmark suite, which should be covered by `turbopack-bench` by https://github.com/vercel/turbo/tree/main/crates/turbopack-bench Test Plan: CI Closes WEB-1653
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
We've rearchitected Next.js+Turbopack so Turbopack does not run reimplement pieces of Next.js in its devserver. This: - Removes references and tests of the `next-dev` binary, which is no longer reachable through `next --turbo`. Uses `next-swc` in its place when testing. - Removes its benchmark suite, which should be covered by `turbopack-bench` by https://github.com/vercel/turbo/tree/main/crates/turbopack-bench Test Plan: CI Closes WEB-1653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've rearchitected Next.js+Turbopack so Turbopack does not run reimplement pieces of Next.js in its devserver. This:
next-devbinary, which is no longer reachable throughnext --turbo. Usesnext-swcin its place when testing.turbopack-benchby https://github.com/vercel/turbo/tree/main/crates/turbopack-benchTest Plan: CI
Closes WEB-1653