Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(turbo): delete Go related release code and config #7205

Merged
merged 4 commits into from
Feb 2, 2024
Merged

chore(turbo): delete Go related release code and config #7205

merged 4 commits into from
Feb 2, 2024

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Feb 1, 2024 •
edited by padmaia
Loading

Closes TURBO-2214

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 10:08pm
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 10:08pm
rust-docs ❌ Failed (Inspect) Feb 1, 2024 10:08pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:08pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:08pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:08pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:08pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:08pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:08pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:08pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:08pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

✅ This change can build next-swc

@mehulkar mehulkar marked this pull request as ready for review February 1, 2024 05:24
@mehulkar mehulkar requested review from a team as code owners February 1, 2024 05:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust benchmark tests (linux)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

chris-olszewski
chris-olszewski requested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost positive we can't just remove our calls to goreleaser without doing some additional work ourselves

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/turborepo-release.yml Outdated Show resolved Hide resolved
cli/Makefile Outdated Show resolved Hide resolved
@chris-olszewski
Copy link
Member

#7221 should fix the integration test failures

@mehulkar mehulkar merged commit 37d1b36 into main Feb 2, 2024
54 of 59 checks passed
@mehulkar mehulkar deleted the mk/delete-more-go branch February 2, 2024 01:45
mehulkar added a commit that referenced this pull request Feb 2, 2024
@mehulkar
chore(turbo): delete Go related release code and config (#7205)
b1001d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci created-by: turborepo owned-by: turbopack owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehulkar @chris-olszewski @sokra