Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: override bad api url on ubuntu runners #8235

Merged
merged 1 commit into from
May 29, 2024
Merged

chore: override bad api url on ubuntu runners #8235

merged 1 commit into from
May 29, 2024

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented May 28, 2024 •
edited
Loading

Description

On the self hosted Ubuntu runners TURBO_API is set to a URL that the Turbo Team doesn't have permission to access leading to a loss of the remote cache functionality.
e.g.
Screenshot 2024-05-28 at 2 31 29 PM
https://github.com/vercel/turbo/actions/runs/9276119063/job/25522446449#step:7:478

This PR overrides this env var so we can leverage the remote cache.

Testing Instructions

The Ubuntu build of turbo should be a cache hit on this PR
Screenshot 2024-05-28 at 2 51 38 PM

https://github.com/actions/runner-images/pull/9941/files#diff-66aec6097318276b09842a3ba2caf3037afbd8dadca2dfcdf76631100613ea69L26

@vercel Vercel
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 9:31pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 28, 2024 9:31pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 28, 2024 9:31pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 28, 2024 9:31pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 28, 2024 9:31pm
examples-native-web ⬜️ Ignored (Inspect) May 28, 2024 9:31pm
examples-svelte-web ⬜️ Ignored (Inspect) May 28, 2024 9:31pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 28, 2024 9:31pm
examples-vite-web ⬜️ Ignored (Inspect) May 28, 2024 9:31pm
rust-docs ⬜️ Ignored (Inspect) May 28, 2024 9:31pm

@chris-olszewski chris-olszewski marked this pull request as ready for review May 28, 2024 21:31
@chris-olszewski chris-olszewski requested review from a team as code owners May 28, 2024 21:31
@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@chris-olszewski chris-olszewski merged commit cc4e5d0 into main May 29, 2024
60 of 62 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_enable_remote_cache_ubuntu branch May 29, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner automatically assigned from vercel/turbo-oss

@codybrouwers codybrouwers Awaiting requested review from codybrouwers codybrouwers is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci created-by: turborepo owned-by: turbopack owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-olszewski @mehulkar