fix equal checks for cells and output #8721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
sokra
commented
Jul 11, 2024
| @@ -43,7 +43,7 @@ pub trait GenerateSourceMap { | |||
| /// The distinction between the source map spec's [sourcemap::Index] and our | |||
| /// [SourceMap::Sectioned] is whether the sections are represented with Vcs | |||
| /// pointers. | |||
| #[turbo_tasks::value(shared)] | |||
| #[turbo_tasks::value(shared, cell = "new")] | |||
There was a problem hiding this comment.
cell = "new" changes the behavior of .cell() to no longer perform an == check and just always override the cell.
There was a problem hiding this comment.
How do we determine which cells should always be overridden?
There was a problem hiding this comment.
When you don't want cells to ever match using equality? Which I imagine should be never unless you've got another bug (e.g. inconsistent cell creation order?).
I agree this seems weird and like we're masking bigger problems.
There was a problem hiding this comment.
When you don't want cells to ever match using equality?
- some types have very expensive equal checks and are very unlikely to be equal (e. g. the parsed AST or the SourceMap)
- some types don't have a equality defined
- some types define equality in a way that it never matches
But in general you want to check equality for early stop bubbling invaliations...
🟢 Turbopack Benchmark CI successful 🟢Thanks |
sokra
commented
Jul 11, 2024
Comment on lines
+59
to
+62
| if let OutputContent::Link(old_target) = &self.content { | ||
| if *old_target == target { | ||
| // unchanged | ||
| return; |
There was a problem hiding this comment.
We can early return when returning the same value again.
Previously this notified all dependent tasks, which is unnecessary.
|
✅ This change can build |
|
bgw
approved these changes
Jul 11, 2024
| @@ -43,7 +43,7 @@ pub trait GenerateSourceMap { | |||
| /// The distinction between the source map spec's [sourcemap::Index] and our | |||
| /// [SourceMap::Sectioned] is whether the sections are represented with Vcs | |||
| /// pointers. | |||
| #[turbo_tasks::value(shared)] | |||
| #[turbo_tasks::value(shared, cell = "new")] | |||
There was a problem hiding this comment.
When you don't want cells to ever match using equality? Which I imagine should be never unless you've got another bug (e.g. inconsistent cell creation order?).
I agree this seems weird and like we're masking bigger problems.
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 16, 2024
* vercel/turborepo#8721 <!-- Tobias Koppers - fix equal checks for cells and output --> * vercel/turborepo#8671 <!-- Tobias Koppers - add unloading of tasks to GC --> * vercel/turborepo#8749 <!-- Tobias Koppers - fix unloading stateful check --> * vercel/turborepo#8750 <!-- Tobias Koppers - upgrade deps to avoid conflict with next.js -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description * Check for equal Vc on returning a value * Avoid PartialEq checks for values that are never equal ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * Check for equal Vc on returning a value * Avoid PartialEq checks for values that are never equal ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * Check for equal Vc on returning a value * Avoid PartialEq checks for values that are never equal ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description * Check for equal Vc on returning a value * Avoid PartialEq checks for values that are never equal ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8721 <!-- Tobias Koppers - fix equal checks for cells and output --> * vercel/turborepo#8671 <!-- Tobias Koppers - add unloading of tasks to GC --> * vercel/turborepo#8749 <!-- Tobias Koppers - fix unloading stateful check --> * vercel/turborepo#8750 <!-- Tobias Koppers - upgrade deps to avoid conflict with next.js -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions