Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Docs: Registering Root Tasks - Incorrect/Unclear example #8973

Closed
wants to merge 2 commits into from

Conversation

nickfujita
Copy link

Description

Updates example for adding a root task, and calling it along with the other package level tasks.

Testing Instructions

Review options listed in issue #8972, and confirm this is the correct implementation of this example.

@nickfujita nickfujita requested review from anthonyshew and a team as code owners August 9, 2024 08:17
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Aug 9, 2024
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 2:23pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 2:23pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 2:23pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 2:23pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 2:23pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 2:23pm

Copy link

vercel bot commented Aug 9, 2024

@nickfujita is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@anthonyshew
Copy link
Contributor

This is a great observation. I'm thinking we should write both of the options you've described into the docs for thoroughness. Would you be up to adding an example of both?

Warning: It's highly likely that I'll be obnoxiously nitpicky about this, because I really like to make sure that we use succinct, excellent language when we're presenting folks with options. If you're ready for me to be mildly annoying about the precise way this gets written, we can keep going on this PR. Otherwise, I can take this on myself in a separate PR so I can be as surgical as I'd like to be without annoying you. 😄

@nickfujita
Copy link
Author

Thanks @anthonyshew
Closing in favor of #9098

@nickfujita nickfujita closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants