Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(tui): only rerender if a non-tick event has been received #9121

Merged
merged 1 commit into from
Sep 6, 2024
Merged

perf(tui): only rerender if a non-tick event has been received #9121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion crates/turborepo-ui/src/tui/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,13 @@ fn run_app_inner<B: Backend + std::io::Write>(
let mut last_render = Instant::now();
let mut resize_debouncer = Debouncer::new(RESIZE_DEBOUNCE_DELAY);
let mut callback = None;
let mut needs_rerender = true;
while let Some(event) = poll(app.input_options()?, &receiver, last_render + FRAMERATE) {
// If we only receive ticks, then there's been no state change so no update
// needed
if !matches!(event, Event::Tick) {
needs_rerender = true;
}
let mut event = Some(event);
let mut resize_event = None;
if matches!(event, Some(Event::Resize { .. })) {
Expand All @@ -606,9 +612,10 @@ fn run_app_inner<B: Backend + std::io::Write>(
if app.done {
break;
}
if FRAMERATE <= last_render.elapsed() {
if FRAMERATE <= last_render.elapsed() && needs_rerender {
terminal.draw(|f| view(app, f))?;
last_render = Instant::now();
needs_rerender = false;
}
}
}
Expand Down
Loading