Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(env mode): allow for tasks to override the global env mode #9157

Conversation

chris-olszewski
Copy link
Member

Description

In response to #9149 (comment) this PR avoids mutating opts when building Run we now set env mode at the task level.

A majority of this PR is adding the ability to set env mode at the task level.

Testing Instructions

Updated integration test (update needed as task hash changed since env mode is now set at the task level instead of the global level).

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 1:41pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Sep 17, 2024 1:41pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Sep 17, 2024 1:41pm
examples-gatsby-web ⬜️ Ignored (Inspect) Sep 17, 2024 1:41pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Sep 17, 2024 1:41pm
examples-native-web ⬜️ Ignored (Inspect) Sep 17, 2024 1:41pm
examples-svelte-web ⬜️ Ignored (Inspect) Sep 17, 2024 1:41pm
examples-tailwind-web ⬜️ Ignored (Inspect) Sep 17, 2024 1:41pm
examples-vite-web ⬜️ Ignored (Inspect) Sep 17, 2024 1:41pm

@chris-olszewski chris-olszewski requested a review from a team as a code owner September 17, 2024 13:41
@chris-olszewski chris-olszewski requested review from tknickman and NicholasLYang and removed request for a team September 17, 2024 13:41
@chris-olszewski chris-olszewski merged commit 6af8473 into chrisolszewski/fdrtn-177-allow-running-turbo-without-turbojson Sep 17, 2024
39 of 40 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_make_run_opt_immutable branch September 17, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants