Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Devcontainer #149

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Update Devcontainer #149

merged 4 commits into from
Jun 17, 2024

Conversation

sitingren
Copy link
Member

Update node version and vertica server version

#os: [ubuntu-latest, windows-latest, macos-latest]
# let's make it a little bit simple for now
# current minimal version will be 12.
# TODO: investigate the multipe version matrix with single Vertica instance
node: ['12', '13', '14', '15', '16', '17']
node: ['12', '14', '16', '18', '20']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change to test against the stable versions of node. I was not aware of what the different versions originally meant.

Copy link
Collaborator

@DMickens DMickens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@sitingren sitingren merged commit 0fdf742 into vertica:master Jun 17, 2024
6 checks passed
@sitingren sitingren deleted the devcontainer branch June 17, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants